Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add required check for NPM build back #719

Closed
kesselb opened this issue Aug 13, 2024 · 1 comment
Closed

Add required check for NPM build back #719

kesselb opened this issue Aug 13, 2024 · 1 comment
Labels
0. Needs triage Pending approval or rejection. This issue is pending approval. bug Something isn't working

Comments

@kesselb
Copy link
Contributor

kesselb commented Aug 13, 2024

We run into some troubles with #709 and the "NPM build" check and therefore removed it temporary.

The workflow https://github.com/nextcloud/end_to_end_encryption/blob/master/.github/workflows/node-when-unrelated.yml can be removed.
@kesselb kesselb added 0. Needs triage Pending approval or rejection. This issue is pending approval. bug Something isn't working labels Aug 13, 2024
@artonge
Copy link
Collaborator

artonge commented Aug 20, 2024

Required check added. Thanks.

@artonge artonge closed this as completed Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0. Needs triage Pending approval or rejection. This issue is pending approval. bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kesselb @artonge