Fix S3 use_ssl and autocreate default values

[aentwist]

Description

From the PHP Manual for getenv, we have

getenv(string $varname, bool $local_only = false): string|false

Returns the value of the environment variable varname, or false if the environment variable varname does not exist.

Now check this out

docker/.config/s3.config.php

Line 3 in a15c755

$use_ssl = getenv('OBJECTSTORE_S3_SSL');

docker/.config/s3.config.php

Line 19 in a15c755

'use_ssl' => (strtolower($use_ssl) === 'false' || $use_ssl == false) ? false : true,

Value not set -> getenv returns false -> use_ssl gets false -> ternary goes to false

This is a great example of why to not allow poorly written code into a codebase. It obfuscates things.

Should probably be

// if defined and value is "false" then set to false
!(getenv('OBJECTSTORE_S3_SSL') && strtolower(getenv('OBJECTSTORE_S3_SSL')) === 'false')
// demorgans law
// if not defined or doesn't have value "false" then set to true
!getenv('OBJECTSTORE_S3_SSL') || strtolower(getenv('OBJECTSTORE_S3_SSL')) !== 'false'

---

There are several other suspicious variables. Using a ternary operator for a boolean expression is redundant. Not relying on truthy falsy values in favor of explicit checks is also somewhat suspicious here.

docker/.config/s3.config.php

Lines 18 to 23 in a15c755

	'autocreate' => (strtolower($autocreate) === 'false' || $autocreate == false) ? false : true,
	'use_ssl' => (strtolower($use_ssl) === 'false' || $use_ssl == false) ? false : true,
	// required for some non Amazon S3 implementations
	'use_path_style' => $use_path == true && strtolower($use_path) !== 'false',
	// required for older protocol versions
	'legacy_auth' => $use_legacyauth == true && strtolower($use_legacyauth) !== 'false'

docker/.config/swift.config.php

Line 8 in a15c755

'autocreate' => $autocreate == true && strtolower($autocreate) !== 'false',

---

Requirements

• build docker image
• set only OBJECTSTORE_S3_BUCKET (use defaults)
• exec in
• examine config/config.php and check default values against README
  • autocreate is true
  • use_ssl is true
  • use_path_style is false
  • legacy_auth is false
• set only OBJECTSTORE_SWIFT_URL
  • autocreate is false

[aentwist]

will pick this up if my other PRs are resolved

[J0WI]

#2309