From b27d360cb68e867fea947875564a90049b459893 Mon Sep 17 00:00:00 2001 From: Claudio Cambra Date: Mon, 28 Oct 2024 13:58:17 +0800 Subject: [PATCH 1/2] Add xml-escaped version of application vendor variable in CMakeLists Signed-off-by: Claudio Cambra --- CMakeLists.txt | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/CMakeLists.txt b/CMakeLists.txt index 27102a6f0e7c..0bc6c48e3473 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -60,6 +60,10 @@ string(REPLACE "&" "&" APPLICATION_NAME_XML_ESCAPED "${APPLICATION_NAME}") string(REPLACE "<" "<" APPLICATION_NAME_XML_ESCAPED "${APPLICATION_NAME_XML_ESCAPED}") string(REPLACE ">" ">" APPLICATION_NAME_XML_ESCAPED "${APPLICATION_NAME_XML_ESCAPED}") +string(REPLACE "&" "&" APPLICATION_VENDOR_XML_ESCAPED "${APPLICATION_VENDOR}") +string(REPLACE "<" "<" APPLICATION_VENDOR_XML_ESCAPED "${APPLICATION_VENDOR_XML_ESCAPED}") +string(REPLACE ">" ">" APPLICATION_VENDOR_XML_ESCAPED "${APPLICATION_VENDOR_XML_ESCAPED}") + if (NOT DEFINED LINUX_PACKAGE_SHORTNAME) set(LINUX_PACKAGE_SHORTNAME "${APPLICATION_SHORTNAME}") endif() From a57eb77131ebb9dc7a665ca7b22730e0b5bdd5a2 Mon Sep 17 00:00:00 2001 From: Claudio Cambra Date: Mon, 28 Oct 2024 13:59:06 +0800 Subject: [PATCH 2/2] Use xml-escaped application vendor in info plist, fixing code-signing issues for vendors with special chars Signed-off-by: Claudio Cambra --- cmake/modules/MacOSXBundleInfo.plist.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cmake/modules/MacOSXBundleInfo.plist.in b/cmake/modules/MacOSXBundleInfo.plist.in index 4fcf27c6a977..54d714f1da02 100644 --- a/cmake/modules/MacOSXBundleInfo.plist.in +++ b/cmake/modules/MacOSXBundleInfo.plist.in @@ -29,7 +29,7 @@ CFBundleShortVersionString @MIRALL_VERSION_STRING@ NSHumanReadableCopyright - (C) 2014-2022 @APPLICATION_VENDOR@ + (C) 2014-2022 @APPLICATION_VENDOR_XML_ESCAPED@ NSSupportsAutomaticGraphicsSwitching NSRequiresAquaSystemAppearance