Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments [$120 awarded] #10

Closed
1 task
juliusknorr opened this issue Feb 1, 2017 · 14 comments
Closed
1 task

Comments [$120 awarded] #10

juliusknorr opened this issue Feb 1, 2017 · 14 comments

Comments

@juliusknorr
Copy link
Member

juliusknorr commented Feb 1, 2017

Similar to the files app it should be possible for users to comment on each card.

  • Check if it is possible to use the server comments app

The $120 bounty on this issue has been claimed at Bountysource.

@joergmschulz
Copy link

I'm not sure how this could be done without cluttering the user interface. I like the simplicity of the current concept (well, dragging the cards would be a plus, you already opened an issue for this one) IMHO it is enough to have the description for the cards.

@juliusknorr
Copy link
Member Author

@joergmschulz I would prefer to keep the markdown description as a default and just use tabs for other stuff like the comments, just like it is handled in the files app.

2017-02-01-193228_511x404_scrot

@jancborchardt
Copy link
Member

Yup, very important for collaboration too. cc @blizzz for comments.

@jancborchardt jancborchardt added this to the 0.3.0 milestone Jun 19, 2017
@blizzz
Copy link
Member

blizzz commented Jun 22, 2017

Yes, it's possible to use comments in other apps. One example that does it is the announcement center app, related PRs: https://github.com/nextcloud/announcementcenter/pulls?q=is%3Apr+comment+is%3Aclosed

@juliusknorr
Copy link
Member Author

Thanks for the hint.

@artemanufrij artemanufrij modified the milestones: 0.3.0, 0.2.1 Jul 4, 2017
@juliusknorr juliusknorr self-assigned this Nov 17, 2017
@juliusknorr juliusknorr modified the milestones: 0.3.0, 0.4.0 Dec 16, 2017
@juliusknorr juliusknorr changed the title Comments Comments [$100] Jun 11, 2018
@juliusknorr juliusknorr modified the milestones: 0.4.0, 0.5.0 Jun 28, 2018
@NebriBlackwing
Copy link
Member

This seems pretty straight forward. @juliushaertl I'd be willing to give this a go. After reading this over it sounds like the majority wishes to see the comments as a tab under the details view that comes up on the right panel after clicking a card?

View screenshot below for how that comments tab would appear. Once you give me the go ahead I'll happily create a new branch for this issue and get to work. Been a long time since I last got to do any angularjs work!

image

@jancborchardt
Copy link
Member

it sounds like the majority wishes to see the comments as a tab under the details view that comes up on the right panel after clicking a card?

Yes – just keep in mind that we also have a plan in the Files app to combine the chronological information (Activity, Comments, Versions) into one timeline. Not sure if anything else is chronological for now, but keep that in mind for the future @juliushaertl @Nebri :)

@juliusknorr
Copy link
Member Author

Good point @jancborchardt We need to remind that for comments and activity #211

@JumpLink
Copy link

@Nebri Do you want to implement this feature? Did you need help?

@NebriBlackwing
Copy link
Member

@JumpLink No thank you, this is currently being handled by @juliushaertl . When I started commenting on this issue I had missed the fact that he is currently assigned to this task.

@laurentiu2
Copy link

laurentiu2 commented Aug 21, 2018

this is currently being handled by @juliushaertl

and from nov 17, 2017 since Julius assigned himself, nothing happened! Wouldn't be better if Ryan handles this? btw awesome work on REST API :)

@juliusknorr
Copy link
Member Author

@laurentiu2 @JumpLink Comments and activity have actually gotten a high priority issue in the last month so I'm activly working on it right now. Expect a pull request soon. Both features will land in the next relase probably around end of september.

@JumpLink
Copy link

Nce to hear, good luck!

@NebriBlackwing
Copy link
Member

@laurentiu2 I appreciate your kind words regarding my work on the REST api. I would like to also gently remind that juliushaertl has much more on his plate regarding deck. Typically Pull Requests are created when one of two things happen. We need feedback on the work in progress, or we believe the work is ready to be reviewed for a merge. Just because you haven't seen the pull request yet, doesn't mean there isn't a branch with the work being done yet. Patience my friends, together deck will continue to improve. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants