Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"OTHER phone" vs "Other email" #3403

Closed
ChristophWurst opened this issue May 24, 2023 · 4 comments · Fixed by nextcloud/server#38454
Closed

"OTHER phone" vs "Other email" #3403

ChristophWurst opened this issue May 24, 2023 · 4 comments · Fixed by nextcloud/server#38454
Assignees
Labels
3. to review Waiting for reviews bug Something isn't working feature: contacts

Comments

@ChristophWurst
Copy link
Member

Describe the bug

(System address book) contacts with phone and email set to type=other show in capital letters for phone.

Steps to reproduce

  1. Add a phone number and set the scope to local
  2. Add an additional email and set the scope to local
  3. Open the contact page of a system contact

Expected behavior

"Other" for both properties

Actual behavior

"OTHER" for phone

Contact version

No response

Operating system

No response

PHP engine version

None

Web server

None

Database

None

Additional info

No response

@ChristophWurst ChristophWurst added bug Something isn't working 1. to develop Accepted and waiting to be taken care of feature: contacts labels May 24, 2023
@ChristophWurst ChristophWurst moved this to 📄 To do (~10 entries) in 💌 📅 👥 Groupware team May 24, 2023
@GretaD GretaD self-assigned this May 24, 2023
@GretaD
Copy link
Contributor

GretaD commented May 24, 2023

After pulling on server, i cannot save the phone number anymore.

I think this capitalization issue is caused by this:

https://github.com/nextcloud/server/blob/e6038268d8e79e3c78f03ea73aa3e4df6bea26af/apps/settings/css/settings.scss#L872-L874

as i cannot find any string "OTHER" in capitals. I cannot test it right now because of the saving problem but im having a look

@ChristophWurst
Copy link
Member Author

as i cannot find any string "OTHER" in capitals

It might come from the vcf data of the contact. Export the contact and inspect the file.

@ChristophWurst
Copy link
Member Author

ChristophWurst commented May 25, 2023

https://www.rfc-editor.org/rfc/rfc6350.html#section-6.4.1 I don't think type=other is correct

type-param-tel = "text" / "voice" / "fax" / "cell" / "video"
                    / "pager" / "textphone" / iana-token / x-name
       ; type-param-tel MUST NOT be used with a property other than TEL.

@ChristophWurst
Copy link
Member Author

https://github.com/nextcloud/server/blob/1f2a9de11263cc6a5dade431a4671a3053be1930/apps/dav/lib/CardDAV/Converter.php#L92 has to be chagned to TYPE=VOICE

If you update your phone number after it shows as Home

image

@ChristophWurst ChristophWurst added 3. to review Waiting for reviews and removed 1. to develop Accepted and waiting to be taken care of labels May 25, 2023
@ChristophWurst ChristophWurst moved this from 📄 To do (~10 entries) to 🏗️ In progress in 💌 📅 👥 Groupware team May 25, 2023
@github-project-automation github-project-automation bot moved this from 🏗️ In progress to ☑️ Done in 💌 📅 👥 Groupware team May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working feature: contacts
Projects
Development

Successfully merging a pull request may close this issue.

2 participants