Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search highlight #648

Closed
vdtoorn opened this issue Apr 18, 2023 · 1 comment · Fixed by #1368 or nextcloud/text#6052
Closed

Search highlight #648

vdtoorn opened this issue Apr 18, 2023 · 1 comment · Fixed by #1368 or nextcloud/text#6052
Assignees
Labels
enhancement New feature or request 🍂 2024-Autumn

Comments

@vdtoorn
Copy link

vdtoorn commented Apr 18, 2023

Is your feature request related to a problem? Please describe.
When using collectives with somewhat large pages, it is very hard to find a searched text, because the search only every shows the page and does not highlight the text. Also, ctrl-F to search in the browser window does not work, because that is overruled by the global search option, and '/' to search is crippled somehow too.

Describe the solution you'd like
At the minimal it would be advantageous to highlight the current search terms in the current collective window. Alternatively, going through the result list could jump to the correct location within the collective page.

Describe alternatives you've considered
I can't think of alternatives other than '/', but that also does not work for me if the search term is in the pages list for instance.

Additional context

@vdtoorn vdtoorn added the enhancement New feature or request label Apr 18, 2023
@juliusknorr juliusknorr moved this to 🧭 Planning evaluation (don't pick) in 📝 Office team Apr 4, 2024
@juliusknorr juliusknorr moved this from 🧭 Planning evaluation (don't pick) to 📄 To do (~10 entries) in 📝 Office team Apr 4, 2024
@juliusknorr
Copy link
Member

ueberdosis/tiptap#2075 could be some useful inspiration for implementing highlights in text

@juliusknorr juliusknorr moved this from 📄 To do (~10 entries) to 🏗️ In progress in 📝 Office team Jun 6, 2024
@jancborchardt jancborchardt moved this to 🏗️ At engineering in 🖍 Design team Jun 6, 2024
@elzody elzody linked a pull request Jul 15, 2024 that will close this issue
5 tasks
@github-project-automation github-project-automation bot moved this from 🏗️ At engineering to 🎉 Done in 🖍 Design team Jul 23, 2024
@github-project-automation github-project-automation bot moved this from 🏗️ In progress to ☑️ Done in 📝 Office team Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request 🍂 2024-Autumn
Projects
Archived in project
Archived in project
4 participants