Mail is send as somebody when using Circles

[Gerben-W]

When sharing files with a single mail address, the subject of the mail contains the user that shares this file.
( USERNAME shared »FILENAME« with you )

But when sharing to a Circle, the subject of the mail contains "someone".
( someone shared a file with you. )

Is it possible to change the mail subject so that the username is in the subject just like sharing a file with a single mail address?

[Noki77]

I diagnosed this a fair bit now, as i saw this behaviour as well after a sharing attempt of one of our customers bounced...
seems like the issue is caused by ShareWrapper::hasInitiator returning false in ShareCreatedSendMail.php#L165, though I haven't figured out why yet...
In my case I "fixed" the issue by simply replacing "someone" within the mail subject by using an event listener on the BeforeMessageSent Event in a custom NextCloud App, that i'm using anyway for having certain email templates based on the user mail address or groups.

So if you still want to "fix" this yourself and you're willing to go through the effort of making an own NC app for it, here is basically what you need to do:

• Create a custom app (just follow the docs or use the app skeleton generator by NextCloud)
• write an event listener on \OCA\Circles\Events\AddingCircleMemberEvent, that fetches the circle owner and stores it somewhere (in my case I have an Application::setDispatchingUser function
• write an event listener on OCP\Mail\Events\BeforeMessageSent that first checks whether a circle owner was found earlier (in my case just check whether Application::getDispatchingUser() is not null), then whether $event->getMessage()->getSubject() contains the word "someone" (yes, IMessage doesn't have a getSubject() function, but \OC\Mail\Message does, maybe check if it's an instance of it first) and lastly replace "someone" with the previously fetched circle owners' display name
• register both listeners in your Application::register method

Edit: since I did this stuff anyway, I published an app adding the workaround here: https://github.com/Noki77/workaround_circles_mails

[Gerben-W]

@Noki77 Thanks for helping with this.
Loved your solution and thinking of implementing this.
Unfortunately I only have one concern you might be able to help with.
In the mail which is send out, the body contains the Circle name, which can be anything (even non positive names to group a certain amount of people). Do you know how to easily replace the circle name with the word "you" in the mail that is send out.
Basically that the mail looks more like the standard mail that is send to one person in stead of a Circle.

Thank you.

[Noki77]

@Gerben-W happy to hear it works out for you!
Good idea with the circle name, i'll look into how it could be implemented.

[spanje]

@Noki77 : It would be really great if you could implement this :-)

[Jerome-Herbinet]

I'm still having that problem with the last contacts + teams apps in NC 29. Mail is sent by "someone" (in e-mails subject an body). That's pretty weird and may damage UX. @ArtificialOwl or @nickvergessen, what do you think ?

Here is what I get (IMO, the share issuer should be indicated instead of "someone", because without that information, some recipients could suspect spamming) :

It may be interesting to work on this at the same moment as #1239

[nickvergessen]

I can point you to the search results:

circles/lib/Listeners/Files/ShareCreatedSendMail.php

Line 131 in f725eca

$author = 'someone';

circles/lib/Listeners/Files/MemberAddedSendMail.php

Line 95 in f725eca

$author = 'someone';

String is not translated and even if translated it should not be inserted into a string like that as it might not work in every language.

But I'm not the maintainer of the app, so I'm unsubscribing again

[Jerome-Herbinet]

I can point you to the search results:

circles/lib/Listeners/Files/ShareCreatedSendMail.php

Line 131 in f725eca

$author = 'someone';

circles/lib/Listeners/Files/MemberAddedSendMail.php

Line 95 in f725eca

$author = 'someone';

String is not translated and even if translated it should not be inserted into a string like that as it might not work in every language.

But I'm not the maintainer of the app, so I'm unsubscribing again

How can I get the maintainers' list of an app, in order to ping the right persons ?