Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small UX improvements #72

Closed
4 of 5 tasks
eppfel opened this issue Sep 20, 2016 · 22 comments · Fixed by #407
Closed
4 of 5 tasks

Small UX improvements #72

eppfel opened this issue Sep 20, 2016 · 22 comments · Fixed by #407
Labels
3. to review Waiting for reviews design Related to design, interface, interaction design, UX, etc. good first issue Small tasks with clear documentation about how and in which place you need to fix things in. skill:frontend Issues and PRs that require JavaScript/Vue/styling development skills

Comments

@eppfel
Copy link
Member

eppfel commented Sep 20, 2016

I skimmed the calendar and found a lot of small things, we can fix to make the UI more consistent and less crammed.

- [ ] Remove the background/border Box around the label for the selection of month/week/day, because it is not an interactive element
bildschirmfoto 2016-09-20 um 08 35 22

bildschirmfoto 2016-09-20 um 08 36 48

  • Do not (/ do only visually) disable the time field (enable it on click, toggle all day event), so the user is not blocked.
  • Place time in the same line as date in details view
  • Make Location and description fields single line with autosize for multiline support (See Bring back multiline comments server#1407)

Maybe a bigger thing to do in a separate window, but wanted to start the discussion:

@nextcloud/designers Gimme thoughts on this?

@georgehrke If you point me to the right places, i can fiddle with it myself.

@eppfel eppfel added 1. to develop Accepted and waiting to be taken care of design Related to design, interface, interaction design, UX, etc. enhancement-proposed skill:frontend Issues and PRs that require JavaScript/Vue/styling development skills labels Sep 20, 2016
@georgehrke
Copy link
Member

@nextcloud/calendar

@ccoenen
Copy link

ccoenen commented Sep 20, 2016

I could swear, the "july 2016" used to be clickable just a few days ago? It did bring up a tiny calendar. Maybe it's just currently broken?

@georgehrke
Copy link
Member

Yes, it is ...
#48

@ccoenen
Copy link

ccoenen commented Sep 20, 2016

(removed)

@georgehrke georgehrke added this to the 1.5.0-current milestone Sep 20, 2016
@georgehrke
Copy link
Member

@ccoenen there is a dedicated issue #25

@ccoenen
Copy link

ccoenen commented Sep 22, 2016

Thanks, I moved my comment over there!

@jancborchardt jancborchardt added the good first issue Small tasks with clear documentation about how and in which place you need to fix things in. label Sep 28, 2016
@jancborchardt
Copy link
Member

Agree with all of @eppfel’s comments, good call! :)

cc @nextcloud/designers @Espina2 as a good example of a nice design details review.

(Btw @georgehrke just cause I notice it atm: Please use the same colors for the labels here (like starter issue) as we do in the server repo.)

@nickvergessen
Copy link
Member

👍 for activating the time field when clicking into it.

@ccoenen
Copy link

ccoenen commented Sep 30, 2016

Clicking: yes!
Tabbing: not in favor of that. Not automatically, at least. Maybe tab to a (visually) deactivated time-input, followed by Spacebar or number keys (or anything but the tab-key), otherwise you could never tab over the time fields without activating them.

@georgehrke
Copy link
Member

I'd be happy to take care of:

  • Do not (/ do only visually) disable the time field (enable it on click, toggle all day event), so the user is not blocked.
  • Make Location and description fields single line with autosize for multiline support (See Bring back multiline comments server#1407)

Although contributions are always welcome 😉

Does someone want to take care of Place time in the same line as date in details view? :)
maybe @eppfel

@eppfel eppfel self-assigned this Oct 25, 2016
@georgehrke georgehrke added 2. developing Work in progress and removed 1. to develop Accepted and waiting to be taken care of labels Dec 10, 2016
@georgehrke
Copy link
Member

Place time in the same line as date in details view

@eppfel Do you mean something like this?

calendar - nextcloud chromium today at 8 25 42 pm

@georgehrke
Copy link
Member

The biggest issue here is on small screens?

In this case the time won't fit next to the date.

What to do here? move ends ... responsively under starts ....?

calendar - nextcloud chromium today at 9 06 11 pm

@eppfel
Copy link
Member Author

eppfel commented Dec 14, 2016

Mh, yeah I fiddle a bit and came to the same conlusion, that the space is too narrow. Switching to date and time in the same field, breaks with the others places we use it. So, we could introduce this only overall.
Moving ends under starts on smaller screens would be fine with me. Or maybe it is not so relevant anymore, because we now have more space due to the Tab-menu in the bottom. Your call 😁

@jancborchardt
Copy link
Member

jancborchardt commented Dec 15, 2016

By the way while we’re talking about space: The dates are quite technical, just numbers. Like 12/05/2016, very non-human. (People are not really good at calculating which number corresponds to which month ;)

Instead it should be displayed like: December 5, 2016 or 5. Dezember 2016 depending on language. Then the space-saving is not possible anyway. Readability is priority. :)

@ccoenen
Copy link

ccoenen commented Dec 15, 2016

As long as i can quickly write a date with just numbers (like 2016-12-15) i'm totally ok with diplaying them in a cooler way.

@jancborchardt
Copy link
Member

@ccoenen Yup, this should ideally only change the display of it. Edit should be possible as now already, and of course there is the datepicker.

@nextcloud/calendar @eppfel what do you think about the date display proposal above?

@georgehrke
Copy link
Member

calendar - nextcloud chromium today at 8 25 42 pm

btw, this is still two inputs. I just removed the borders to make it look like one

@georgehrke
Copy link
Member

georgehrke commented Dec 15, 2016

By the way while we’re talking about space: The dates are quite technical, just numbers. Like 12/05/2016, very non-human. (People are not really good at calculating which number corresponds to which month ;)

That's because I'm using US english as my local. If you use Nextcloud in german it's 05.12.2016

Instead it should be displayed like: December 5, 2016 or 5. Dezember 2016 depending on language. Then the space-saving is not possible anyway. Readability is priority. :)

You want users to enter a date like December 5, 2016?
Sorry, but how are we supposed to parse that with all the different locals out there?

Generally, I think its weird if an input changes its content when I focus it. That's absolutely not what I would expect

@georgehrke
Copy link
Member

calendar - nextcloud chromium today at 7 19 16 pm

you can also see the month name very prominently in the date picker ;)

@georgehrke
Copy link
Member

4 of 5 issues have been fixed, that's good progress! :)

Let's move the last one to 1.6.0

@georgehrke georgehrke modified the milestones: 1.6.0-next, 1.5.0-current Dec 15, 2016
@eppfel eppfel removed their assignment Jan 20, 2017
@georgehrke
Copy link
Member

@eppfel @jancborchardt So, what do we want to do about the date / time picker design? :)

We also need to fix the date / time picker layout in the popover:

There is too much whitespace between starts and ends and the inputs are not fully readable.
nextcloud

@georgehrke
Copy link
Member

Just discussed it with Jan.
Doing it like this:
calendar - nextcloud chromium today at 8 25 42 pm

and move ends ... under starts ... when the sidebar is too narrow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews design Related to design, interface, interaction design, UX, etc. good first issue Small tasks with clear documentation about how and in which place you need to fix things in. skill:frontend Issues and PRs that require JavaScript/Vue/styling development skills
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants