Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use autosize for location and description textareas #237

Closed
jancborchardt opened this issue Dec 15, 2016 · 5 comments
Closed

Use autosize for location and description textareas #237

jancborchardt opened this issue Dec 15, 2016 · 5 comments
Labels
1. to develop Accepted and waiting to be taken care of design Related to design, interface, interaction design, UX, etc. enhancement New feature request Feature: Editor good first issue Small tasks with clear documentation about how and in which place you need to fix things in. needs info

Comments

@jancborchardt
Copy link
Member

Currently when you have a description or long location in the details sidebar, there will be scrolling inside of the scrollable sidebar. This is very ugly. ;)

Instead we should use autosize.js here just like in the Mail app: https://github.com/jackmoore/autosize

Might even be a possibility to consider for inclusion in the server since we should avoid having text fields scroll like that. cc @nextcloud/javascript

@jancborchardt jancborchardt added 1. to develop Accepted and waiting to be taken care of design Related to design, interface, interaction design, UX, etc. enhancement New feature request Feature: Editor sidebar good first issue Small tasks with clear documentation about how and in which place you need to fix things in. labels Dec 15, 2016
@georgehrke
Copy link
Member

Did you try 1.4.1 or master?
we just introduced autosize in master
#227

@jancborchardt
Copy link
Member Author

I tested it in production, not master. So nice work! :)

Btw there is another textarea, the iframe one in the public share link, does this also work for that one? And does really every textarea in the Calendar app now have autosize and resize: none?

@georgehrke
Copy link
Member

I don't think autosize is important for the embed textfield. Most users don't understand the content of the embed field anyway. They are just supposed to copy it.

@georgehrke
Copy link
Member

@jancborchardt ^

Please comment.

@georgehrke
Copy link
Member

Closing.

All important ones have autosize.
The embed one doesn't need autosize in my opinion, because it will add a huge, not editable textarea to the interface. Furthermore most users don't understand the content of the embed textarea anyway, there are just supposed to copy&paste it somewhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of design Related to design, interface, interaction design, UX, etc. enhancement New feature request Feature: Editor good first issue Small tasks with clear documentation about how and in which place you need to fix things in. needs info
Projects
None yet
Development

No branches or pull requests

2 participants