Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grid view: file type icons smaller #3174

Closed
tobiasKaminsky opened this issue Oct 23, 2018 · 5 comments
Closed

Grid view: file type icons smaller #3174

tobiasKaminsky opened this issue Oct 23, 2018 · 5 comments

Comments

@tobiasKaminsky
Copy link
Member

tobiasKaminsky commented Oct 23, 2018

From: nextcloud/server#11902

2018-10-19-083302 2018-10-19-083440

Answer by @jancborchardt:

@tobiasKaminsky nice, already looks much better! It's really visible how the folder icon size looks nicer in comparison to the rest.

  • The other filetype icons also need to be smaller
  • The text below can be moved up a bit (towards the filetype icon)
  • Text size is also a bit large maybe? Is it the same as the file name in list view?
@nextcloud-android-bot

This comment has been minimized.

@AndyScherzinger
Copy link
Member

@tobiasKaminsky @jancborchardt @nextcloud/designers Looks good, also agreeing to the comments, looking at the server issue I see that the webUI will also start shipping a 3-dot menu and I guess the 3-dor and the share icon trigger actions (like we also have in the list), so should we also add this (now) or in a later PR because right now the 3-dot menu isn't present in our grid view, while we then have to think about how to display image thumbnails (which don't have any info displayed except fav and shared status).

@jancborchardt
Copy link
Member

@AndyScherzinger also just for reference, I’m torn regarding the 3-dot-menu for pictures in grid view too. :\ There are already a ton of icons on the images and we need to possibly find a better way.

@AndyScherzinger
Copy link
Member

@jancborchardt yeah, I know what you mean. From my pov people using the grid view for image folders don't really want to interact with the items (except for maybe opening the larger previews with the pager or maybe sharing the file with others). So having a very quick access for file actions not really needed nor helpful. No idea how to properly solve this atm :(

@joshtrichards
Copy link
Member

This looks fixed to me. Can't find the relevant PR (and I suspect there are a couple different ones), but this is what it looks like so I'll close it out.
image
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants