Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BITV] Accessibility issues #898

Closed
3 tasks done
PVince81 opened this issue Aug 29, 2022 · 10 comments · Fixed by #1398
Closed
3 tasks done

[BITV] Accessibility issues #898

PVince81 opened this issue Aug 29, 2022 · 10 comments · Fixed by #1398

Comments

@PVince81
Copy link
Member

PVince81 commented Aug 29, 2022

Bug fixes

Following suggestions were moved to main "Lazy loading" nextcloud/server#33844 issue:

  • navigation via months/time could be useful
  • filtering/search would be useful
@nickvergessen
Copy link
Member

Better to use underline for hover/focus style of the links

Since activity is not reverting a server rule there, would it make sense to do this on a global level? Otherwise we also need to track this for all the links in settings descriptions, notifications, ...

@nickvergessen
Copy link
Member

Lazy loading not accessible as you can not move very far to the past quickly.

You can't anyway as the responses are rather slow and only get 30 entries per grab (could increase that now that the server load was improved with #871

I split the issue list into "bug fixes" which we should do now and "follow up features" which can be done later. Let me know if you agree.

@PVince81
Copy link
Member Author

yeah, lazy loading / moving to pagination is going to be a bigger challenge in multiple fronts anyway...

@ChristophWurst

This comment was marked as resolved.

@PVince81

This comment was marked as resolved.

@nickvergessen
Copy link
Member

Better to use underline for hover/focus style of the links

That should be applied to all Nextcloud? Or what makes it valid here, but e.g. not in notifications etc?

@JuliaKirschenheuter
Copy link
Contributor

JuliaKirschenheuter commented Dec 1, 2022

  • Better to use underline for hover/focus style of the links => Already have as issue

@st3iny
Copy link
Member

st3iny commented Jan 3, 2023

Please check if some of the issues might be fixed by #1043.

@JuliaKirschenheuter
Copy link
Contributor

JuliaKirschenheuter commented Feb 9, 2023

[ ] Clicking on a file should ideally open the image or file in place: right now a redirection to files takes place. File will be opened "in place".

@michaelnissenbaum is this approach ok to you?

@michaelnissenbaum
Copy link

@JuliaKirschenheuter If by 'open in place' you mean that the image/file will be opened on the same page in a viewer/editor, then that's acceptable to me. It's important that the editor/viewer is fully accessible. Additionally, please ensure that once a file or image is opened, the keyboard focus is properly placed and clearly visible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants