Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Top and bottom padding of action menu too much, does not match sides #4870

Closed
jancborchardt opened this issue Nov 22, 2023 · 1 comment · Fixed by #4875
Closed

Top and bottom padding of action menu too much, does not match sides #4870

jancborchardt opened this issue Nov 22, 2023 · 1 comment · Fixed by #4875
Assignees
@marcoambrosini
Labels
2. developing Work in progress bug Something isn't working design Design, UX, interface and interaction design papercut Annoying recurring issue with possibly simple fix. regression Regression of a previous working feature

Comments

@jancborchardt
Copy link
Contributor

jancborchardt commented Nov 22, 2023 •
edited
Loading

Note that the top (and bottom) whitespace in the action menu is much larger than the left and right. This didn’t happen in the previous release and looks off:
image

Edit: Example of bottom padding, in Talk (same issue of course with top padding here too):
image

cc @szaimen @marcoambrosini
@jancborchardt jancborchardt added bug Something isn't working 1. to develop Accepted and waiting to be taken care of regression Regression of a previous working feature design Design, UX, interface and interaction design papercut Annoying recurring issue with possibly simple fix. labels Nov 22, 2023
@AndyScherzinger
Copy link
Contributor

-> not blocked by feature freeze

@jancborchardt jancborchardt moved this to 🏗️ At engineering in 🖍 Design team Nov 22, 2023
@jancborchardt jancborchardt moved this from 🏗️ At engineering to 📐 Design phase in 🖍 Design team Nov 22, 2023
@marcoambrosini marcoambrosini self-assigned this Nov 22, 2023
@marcoambrosini marcoambrosini mentioned this issue Nov 23, 2023
Merged
3 tasks
@szaimen szaimen added 2. developing Work in progress and removed 1. to develop Accepted and waiting to be taken care of labels Nov 23, 2023
@jancborchardt jancborchardt mentioned this issue Nov 23, 2023
Closed
13 tasks
@github-project-automation github-project-automation bot moved this from 📐 Design phase to 🎉 Done in 🖍 Design team Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marcoambrosini marcoambrosini

Labels
2. developing Work in progress bug Something isn't working design Design, UX, interface and interaction design papercut Annoying recurring issue with possibly simple fix. regression Regression of a previous working feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove server styles from action menu nextcloud-libraries/nextcloud-vue
4 participants
@jancborchardt @AndyScherzinger @marcoambrosini @szaimen