Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add submenus to action menus #4698

Closed
marcoambrosini opened this issue Oct 25, 2023 · 4 comments
Closed

Add submenus to action menus #4698

marcoambrosini opened this issue Oct 25, 2023 · 4 comments

Comments

@marcoambrosini
Copy link
Contributor

marcoambrosini commented Oct 25, 2023

I think that for this we should use floating-vue's submenus instead of our current strategy for actions

https://floating-vue.starpad.dev/guide/component#sub-menu

Screen.Recording.2023-10-25.at.16.50.37.mov

ref nextcloud/server#41010

cc @nextcloud-libraries/designers

@susnux
Copy link
Contributor

susnux commented Oct 26, 2023

Are we sure we ever want submenus? I remember some discussion with @jancborchardt but not sure how it ended 😅

I think the outcome was that submenus are bad for UX and we should rather use modals for more specific settings, but maybe I do not remember this correctly.

@nimishavijay
Copy link

We have used a "second level" menu in multiple places (send later in mail, remind me/snooze, more actions in mail, more properties in contacts) so I would say it is used enough that it could become a component. Agreed that we could use modals for specific settings though, I think having a "second level" menu is useful in its own right :)

The styling of the components remains an open question though. This kind of cascading submenu is common on desktop apps, but it may not be responsive (not much available horizontal space on mobile screens) and may cause issues when the parent menu is on the corner of a screen. Since we also use this for "more actions" or "more items" the pagination pattern makes more sense than something that appears on the right. What do you think?

@szaimen
Copy link
Contributor

szaimen commented Nov 5, 2023

but it may not be responsive (not much available horizontal space on mobile screens) and may cause issues when the parent menu is on the corner of a screen. Since we also use this for "more actions" or "more items" the pagination pattern makes more sense than something that appears on the right. What do you think?

I agree 👍

@marcoambrosini
Copy link
Contributor Author

👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants