Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IDE / JEST fail to parse some CommonJS files #4592

Closed
Tracked by #10626
Antreesy opened this issue Oct 2, 2023 · 2 comments · Fixed by #4596
Closed
Tracked by #10626

IDE / JEST fail to parse some CommonJS files #4592

Antreesy opened this issue Oct 2, 2023 · 2 comments · Fixed by #4596
Labels
0. to triage bug Something isn't working

Comments

@Antreesy
Copy link
Contributor

Antreesy commented Oct 2, 2023 •
edited
Loading

Noticed when tried to bump library from 7.12.5 to 8.0.0.beta-7

  • Some bundled files compiled with Syntax error (around block of imports, could be found by empty css)
    • NcHeaderMenu.cjs
    • NcAppNavigationSettings.cjs
    • NcListItemIcon.cjs
  • Replacing comma with semocolon resolves problem

image
@Antreesy Antreesy added bug Something isn't working 0. to triage labels Oct 2, 2023
@Antreesy Antreesy mentioned this issue Oct 2, 2023
Merged
61 tasks
@susnux
Copy link
Contributor

susnux commented Oct 2, 2023

Seems to be a problem of esbuild minify and the vite css plugin, see vitejs/vite#14515

@susnux
Copy link
Contributor

susnux commented Oct 2, 2023

I create a PR for a work-around (just skip minify any whitespace, like we do for esm).

@susnux susnux mentioned this issue Oct 2, 2023
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0. to triage bug Something isn't working
Projects
None yet
Milestone
No milestone
2 participants
@susnux @Antreesy