Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unscoped #content CSS from NcGuestContent breaks global content usage #3534

Closed
nickvergessen opened this issue Dec 1, 2022 · 3 comments · Fixed by #3537
Closed

Unscoped #content CSS from NcGuestContent breaks global content usage #3534

nickvergessen opened this issue Dec 1, 2022 · 3 comments · Fixed by #3537
Assignees
@st3iny
Labels
2. developing Work in progress bug Something isn't working regression Regression of a previous working feature

Comments

@nickvergessen
Copy link
Contributor

nickvergessen commented Dec 1, 2022 •
edited
Loading

This is not scoped and therefore breaks files app, settings, basically any page layout by missing the bottom border:

grafik

grafik

Originally posted by @nickvergessen in #3369 (comment)
@nickvergessen nickvergessen added bug Something isn't working 1. to develop Accepted and waiting to be taken care of regression Regression of a previous working feature labels Dec 1, 2022
@nickvergessen
Copy link
Contributor Author

Then again there is no id #content in this component, which element did you try to target or is it remaining bits from copy-paste? @ChristophWurst

@st3iny
Copy link
Contributor

st3iny commented Dec 1, 2022

It is deliberately targeting the root div outside of the component itself. Otherwise, the bottom of the guest content component looks weird because of the margin/padding.

I wasn't aware that the style is applied globally.

@nickvergessen
Copy link
Contributor Author

Visit personal settings on c.nc.c for reference

@st3iny st3iny added 2. developing Work in progress and removed 1. to develop Accepted and waiting to be taken care of labels Dec 2, 2022
@st3iny st3iny self-assigned this Dec 2, 2022
@st3iny st3iny moved this to 🏗️ In progress in 💌 📅 👥 Groupware team Dec 2, 2022
@st3iny st3iny mentioned this issue Dec 2, 2022
Merged
Repository owner moved this from 🏗️ In progress to ☑️ Done in 💌 📅 👥 Groupware team Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@st3iny st3iny

Labels
2. developing Work in progress bug Something isn't working regression Regression of a previous working feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Scope global #content styles via extra class nextcloud-libraries/nextcloud-vue
2 participants
@nickvergessen @st3iny