Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid CSS for NcModel #3123

Closed
raimund-schluessler opened this issue Aug 30, 2022 · 3 comments · Fixed by #3130
Closed

Invalid CSS for NcModel #3123

raimund-schluessler opened this issue Aug 30, 2022 · 3 comments · Fixed by #3130
Labels
3. to review Waiting for reviews feature: modal Related to the modal component low Low priority
Milestone
6.0.0

Comments

@raimund-schluessler
Copy link
Contributor

This line of CSS is invalid:
https://github.com/nextcloud/nextcloud-vue/blob/c73eb5852dc2641115d524012dad8f14bf8a0f78/src/components/NcModal/NcModal.vue#L859

But since I don't know what is intended here, I just summon @Pytal, @skjnldsv and @PVince81 since you touched it last 🙈
@raimund-schluessler raimund-schluessler added this to the 6.0.0 milestone Aug 30, 2022
@raimund-schluessler raimund-schluessler added bug Something isn't working 1. to develop Accepted and waiting to be taken care of feature: modal Related to the modal component labels Aug 30, 2022
@skjnldsv
Copy link
Contributor

It's part of the rule above

transition: opacity 250ms,
		visibility 250ms

@raimund-schluessler
Copy link
Contributor Author

Ah, damn it. Of course. Sorry I didn't realize this. But it explains why the linter complained about a missing tab there, but not about invalid CSS. 🙈
I will send a PR to get the tab fixed 😄

@raimund-schluessler raimund-schluessler mentioned this issue Aug 31, 2022
Merged
@raimund-schluessler raimund-schluessler added 3. to review Waiting for reviews low Low priority and removed bug Something isn't working 1. to develop Accepted and waiting to be taken care of labels Aug 31, 2022
@skjnldsv
Copy link
Contributor

🤗

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3. to review Waiting for reviews feature: modal Related to the modal component low Low priority
Projects
None yet
Milestone
6.0.0
Development

Successfully merging a pull request may close this issue.

Add missing tab in NcModal CSS nextcloud-libraries/nextcloud-vue
2 participants
@raimund-schluessler @skjnldsv