Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove icon class support for Actions #3007

Open
2 tasks
PVince81 opened this issue Aug 11, 2022 · 1 comment
Open
2 tasks

Remove icon class support for Actions #3007

PVince81 opened this issue Aug 11, 2022 · 1 comment
Labels
breaking PR that requires a new major version technical debt
Milestone
9.0.0

Comments

@PVince81
Copy link
Contributor

This will be a breaking change because all apps and server will have to switch to Vue icons.
Probably it's best to first deprecate this somehow and start removing once most of the migration is done already.

Ref #3006

  • remove icon class support for single action item
  • remove icon class support on actionText mixin
@PVince81 PVince81 added technical debt breaking PR that requires a new major version labels Aug 11, 2022
@PVince81 PVince81 mentioned this issue Aug 11, 2022
Merged
@nickvergessen
Copy link
Contributor

Weather plugin in the Dashboard heavily relies on this btw.

@susnux susnux added this to the 9.0.0 next Vue 3 milestone Nov 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking PR that requires a new major version technical debt
Projects
None yet
Milestone
9.0.0
Development

No branches or pull requests
3 participants
@nickvergessen @PVince81 @susnux