Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.6] Spacing issue for title input #1347

Open
georgehrke opened this issue Aug 25, 2020 · 5 comments
Open

[2.6] Spacing issue for title input #1347

georgehrke opened this issue Aug 25, 2020 · 5 comments
Assignees
Labels
1. to develop Accepted and waiting to be taken care of bug Something isn't working feature: app-sidebar Related to the app-sidebar component regression Regression of a previous working feature

Comments

@georgehrke
Copy link
Contributor

B621B5A6-6E61-4B93-BD5D-C24033A3999D

There is a no visible padding between sidebar border and text input.

Also reproducible https://nextcloud-vue-components.netlify.app/#/Components/App%20containers?id=appsidebar-1
0CDBCE19-9810-4972-8B1F-D64DC4115D3A

@georgehrke georgehrke added bug Something isn't working regression Regression of a previous working feature 1. to develop Accepted and waiting to be taken care of feature: app-sidebar Related to the app-sidebar component labels Aug 25, 2020
@skjnldsv
Copy link
Contributor

skjnldsv commented Aug 27, 2020

Please check again with master.

@raimund-schluessler
Copy link
Contributor

raimund-schluessler commented Aug 27, 2020

This is still the case, and it kind of was by design. @jancborchardt stated #1090 (comment) that we don't want the title to move when switching to edit mode.

Hence, when we want padding on the left of the input and a static title, we would need to move the whole title to the right, which might look a bit weird in non-edit mode. Adding padding on the right should be simpler, as there usually is space left anyway.

So once we decided how it should look like, I can take care of it.

@raimund-schluessler
Copy link
Contributor

By the way, your second screenshot shows to much padding on the right of the title if no tertiary action is present. I will adjust the visual tests and fix this.

@georgehrke
Copy link
Contributor Author

Please check again with master.

Still the case in 2.6.4

@raimund-schluessler
Copy link
Contributor

Ping @jancborchardt for input on the input 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of bug Something isn't working feature: app-sidebar Related to the app-sidebar component regression Regression of a previous working feature
Projects
None yet
Development

No branches or pull requests

3 participants