-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation for VC database fields #977
Comments
As an example we generate models docs in SCIO here https://scancodeio.readthedocs.io/en/latest/data-models.html |
@johnmhoran We need to widen this page in the RTD as you did for the Audit/Analysis/SPATS RTD. There are already 2 tables there that you cannot read in portrait-only format so we need landscape even before considering how to display a DB diagram. It would be best if you can just widen the page for now since we have not polled the team on changing look & feel overall. |
Will do @mjherzog . |
@mjherzog I've added some simple CSS and folder structure etc. and the vulnerablecode RTD page now has the wide look of the other RTD. The latter has much more CSS for various widgets, dropdowns, a navbar etc. and I'm not proposing we add all of that to the vulnerablecode RTD. However, before I commit and push I could show you what we now have locally and get any immediate additional feedback you might have. Comparisons pasted below. How would you like to proceed? Before: After: |
Please proceed with the width change for now. I think that we will want to make landscape and a default and add some or all of the other features from the private RTDs, but we need to engage a broader group who are interested in our doc style. I am guessing Ayan, Dennis, Thomas and Philippe, but we need to open the floor to all nexB people and likely the AboutCode community people who are interested. |
OK. |
Reference: #977 Note: I just noticed that I named the branch with 997 but the issue is 977. Signed-off-by: John M. Horan <[email protected]>
…#977 Reference: #977 Signed-off-by: John M. Horan <[email protected]>
@mjherzog I've reviewed my 2022 notes, created a new test branch, loaded/installed various packages including graphviz, and my initial simple command produced this -- a start. |
* Widen the RTD page #997 Reference: #977 Note: I just noticed that I named the branch with 997 but the issue is 977. Signed-off-by: John M. Horan <[email protected]> * Add width, margin and padding adjustments for mobile displays <= 768px #977 Reference: #977 Signed-off-by: John M. Horan <[email protected]> --------- Signed-off-by: John M. Horan <[email protected]>
@johnmhoran Thank you for the diagram! It seems from top-down that there are two major chunks here:
|
@mjherzog Here's an example of the application group: and the admin group: |
We should add these to the VulnerableCode RTD documentation - presumably a new sub-section in the Reference section. |
Reference: #977 Signed-off-by: John M. Horan <[email protected]>
Reference: #977 Signed-off-by: John M. Horan <[email protected]>
@mjherzog I've added a new https://vulnerablecode--1350.org.readthedocs.build/en/1350/reference_model_overview.html |
Reference: #977 Signed-off-by: John M. Horan <[email protected]>
Reference: #977 Signed-off-by: John M. Horan <[email protected]>
* Add graph model diagrams #977 Reference: #977 Signed-off-by: John M. Horan <[email protected]> * Add django-extensions to setup.cfg #977 Reference: #977 Signed-off-by: John M. Horan <[email protected]> --------- Signed-off-by: John M. Horan <[email protected]>
The diagrams look good. We will need a process to keep them in sync with Model changes over time, but closing this Issue because it has been completed. |
We need to add Reference documentation for the VulnerableCode database fields. Perhaps we can regenerate the diagrams that @johnmhoran created about a month ago (copies attached). We may need to figure out how to create them in a narrower width format because is it annoying to scroll for this type of diagram - see https://vulnerablecode.readthedocs.io/en/latest/reference_framework_overview.html.
This may be the time to widen our RTD page format.
The text was updated successfully, but these errors were encountered: