Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not pass silently on ClientResponseError #97

Open
pombredanne opened this issue Jun 14, 2021 · 0 comments
Open

Do not pass silently on ClientResponseError #97

pombredanne opened this issue Jun 14, 2021 · 0 comments
Labels
bug Something isn't working

Comments

@pombredanne
Copy link
Member

Several importers or fetcher fail silently on ClientResponseError such as here https://github.com/nexB/vulnerablecode/blob/24e33966bae6124e381556e520e18f1129c352fc/vulnerabilities/package_managers.py#L147

We should never fail silently unless it is really needed.
@pombredanne pombredanne mentioned this issue Jun 14, 2021
Merged
@pombredanne pombredanne added the bug Something isn't working label Jan 24, 2022
@TG1999 TG1999 transferred this issue from aboutcode-org/vulnerablecode Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pombredanne