Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Project and Codescan Identifier fields to Conclusions file #226

Closed
mjherzog opened this issue Jan 30, 2018 · 1 comment
Closed

Add Project and Codescan Identifier fields to Conclusions file #226

mjherzog opened this issue Jan 30, 2018 · 1 comment

Comments

@mjherzog
Copy link
Member

We need to add Project and Codescan Identifier fields to the Conclusions file for grouping Conclusion files by Project and tracking a Conclusions file back to the corresponding scan file/activity. Some key design assumptions / questions are:

  • Both fields are labels, i.e. not validated.
  • The overall logic is that one AboutCode Project may have multiple Codescan Identifiers where the latter identifies a Scan/Conclusions file. The use case is that there may be multiple Scan/Conclusions files - e.g. where the product codebase is in multiple repos.
  • Both fields should be stored at the Conclusions file level for ease-of-use and consistency across a Scan/Conclusions file.
  • It may make sense to enter/generate either or both fields during a scan where you might specify the Project in your scan parameters and ScanCode generates a Codescan Identifier.
  • For Codescan Identifier we need to think about possible confusion between an internal identifier in the Scan/Conclusions file versus the external filename.
@mjherzog
Copy link
Member Author

mjherzog commented May 9, 2022

Closing because we are deprecating the Conclusions feature.

@mjherzog mjherzog closed this as completed May 9, 2022
@mjherzog mjherzog removed this from the Release v3.3.0 milestone May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants