From a438bf79e50ba022e06f5f7b04068333cf4e645a Mon Sep 17 00:00:00 2001
From: Exempt-Medic <60412657+Exempt-Medic@users.noreply.github.com>
Date: Sat, 27 Jul 2024 15:49:27 -0400
Subject: [PATCH] Change yhorm default (#30)

---
 worlds/dark_souls_3/__init__.py | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/worlds/dark_souls_3/__init__.py b/worlds/dark_souls_3/__init__.py
index 06e8fa185d5f..7728c878a096 100644
--- a/worlds/dark_souls_3/__init__.py
+++ b/worlds/dark_souls_3/__init__.py
@@ -67,7 +67,7 @@ class DarkSouls3World(World):
     location_descriptions = location_descriptions
     item_descriptions = item_descriptions
 
-    yhorm_location: Optional[DS3BossInfo]
+    yhorm_location: DS3BossInfo = default_yhorm_location
     """If enemy randomization is enabled, this is the boss who Yhorm the Giant should replace.
     
     This is used to determine where the Storm Ruler can be placed.
@@ -98,8 +98,6 @@ def generate_early(self) -> None:
                     for boss in all_bosses:
                         if yhorm_data.startswith(boss.name):
                             self.yhorm_location = boss
-                else:
-                    self.yhorm_location = default_yhorm_location
 
         # Randomize Yhorm manually so that we know where to place the Storm Ruler.
         elif self.options.randomize_enemies:
@@ -115,8 +113,6 @@ def generate_early(self) -> None:
                 )
             ):
                 self.multiworld.local_early_items[self.player]["Storm Ruler"] = 1
-        else:
-            self.yhorm_location = default_yhorm_location
 
     def _allow_boss_for_yhorm(self, boss: DS3BossInfo) -> bool:
         """Returns whether boss is a valid location for Yhorm in this seed."""