Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NewsKit docs site - Typography preset examples incorrect #842

Open
nathanparris opened this issue Apr 20, 2023 · 0 comments
Open

NewsKit docs site - Typography preset examples incorrect #842

nathanparris opened this issue Apr 20, 2023 · 0 comments
Labels
docs Improvements or additions to documentation

Comments

@nathanparris
Copy link
Contributor

nathanparris commented Apr 20, 2023

Describe the bug

The typography preset examples are being shown as the NewsKit docs theme, rather than NewsKit.
Main difference is that editorial styles should be Bitter, not Poppins.

I believe this has happened during the theme updates to use Publisher package

To Reproduce

Steps to reproduce the behavior:

  1. Go to https://newskit.co.uk/theme/presets/typography-presets/#default-typography-presets

Expected behavior

Typography examples should be displayed using the NewsKit theme

editorial typography presets should be in Bitter not Poppins

Screenshots / Video / Test Environment

If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: Mac
  • Browser: Chromium 112.0.5615.138.

Additional context

Add any other context about the problem here.

@nathanparris nathanparris added bug Something isn't working triage This issue will be reviewed by the team labels Apr 20, 2023
@github-project-automation github-project-automation bot moved this to Triage in NewsKit Apr 20, 2023
@jps jps moved this from Triage to Analysis in NewsKit Apr 25, 2023
@GeriReid GeriReid removed the triage This issue will be reviewed by the team label Apr 27, 2023
@jps jps added docs Improvements or additions to documentation and removed bug Something isn't working labels May 2, 2023
@LukeFinch LukeFinch moved this from Analysis to Ready to do in NewsKit May 11, 2023
@LukeFinch LukeFinch added bug Something isn't working and removed bug Something isn't working labels May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation
Projects
Status: Ready to do
Development

No branches or pull requests

4 participants