Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Bug) - Update default focus state for Components #770

Open
mstuartf opened this issue Mar 24, 2023 · 0 comments
Open

(Bug) - Update default focus state for Components #770

mstuartf opened this issue Mar 24, 2023 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@mstuartf
Copy link
Contributor

Describe the bug

There are focus state issues across some NewsKit components and on the NewsKit documentation site, where the correct focus preset is not being referenced - resulting in a mix of NewsKit and user-agent styles.

Design: https://www.figma.com/file/1Hwdf8JOtZbismmNK7WPEi/Focus-states-fixes?node-id=1%3A44&t=0zUKHXJFLujV5j7N-11

To Reproduce

Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior

A clear and concise description of what you expected to happen.

Screenshots / Video / Test Environment

If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context

Add any other context about the problem here.

@mstuartf mstuartf added bug Something isn't working triage This issue will be reviewed by the team labels Mar 24, 2023
@mstuartf mstuartf self-assigned this Mar 24, 2023
@mstuartf mstuartf added this to NewsKit Mar 24, 2023
@mstuartf mstuartf moved this to Ready to deploy in NewsKit Mar 24, 2023
@jps jps removed the triage This issue will be reviewed by the team label Mar 27, 2023
@mutebg mutebg moved this from Ready to deploy to Done in NewsKit Apr 10, 2023
@mutebg mutebg moved this from Done to Ready to deploy in NewsKit Apr 10, 2023
@newskit-engineering newskit-engineering moved this from Ready to deploy to Done in NewsKit Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

2 participants