feat(workloads): add a workloads resource #474
Conversation
There was a problem hiding this comment.
Hey @ctrombley, I'm a big fan of the testing section of this resource with how well tested it in fact is. I did have some issues though and it's mostly around the maintainability aspect. I was struggling to scan through this resource and see how all the pieces fit together. I was constantly floating back and forth between the schema and the create/update/read methods and then moving to another file and then back up and all around just to see how all the pieces fit together. I've written out some directions on how to take a more organized approach and a few other suggestions on areas where you can simplify things and remove some unnecessary attributes.
Let me know if you have any other questions around anything and I'd be more than happy to discuss further
ghost
added
documentation
ctrombley
force-pushed
the
feat/workloads
branch
from
1d31819
to
9b83c8d
Compare
|
Holding off on merging this as we may see some more API changes from the Workloads team. |
* feat(workloads): add a workloads resource * chore(workloads): incorporate linter suggestions * chore(workloads): incorporate code review feedback * docs(workloads): add website documentation * chore(workloads): vendor modules * refactor(workloads): remove query name
Resolves: #436
This PR adds support for New Relic One workloads.