feat(synthetics): add labels resource #407
Conversation
ctrombley
force-pushed
the
feat/synthetics-labels
branch
from
851cee2
to
726f850
Compare
ghost
added
documentation
ctrombley
force-pushed
the
feat/synthetics-labels
branch
from
726f850
to
8929243
Compare
| return nil | ||
| } | ||
|
|
||
| func expandSyntheticsLabel(d *schema.ResourceData) *synthetics.MonitorLabel { |
There was a problem hiding this comment.
Not a blocker, but could potentially put these into the structures_{resource}.go pattern and add some a couple unit tests for expand and flatten.
There was a problem hiding this comment.
however, I see that they are the top-level scenario that we talked about before, so maybe no big deal.
There was a problem hiding this comment.
I left them here since there was no data source that needed to share them.
There was a problem hiding this comment.
This makes sense though, I'll make it so.
There was a problem hiding this comment.
@sanderblue that's right, seems like there is no good way to unit test at the top level since the expand and flatten functions depend on an instace of schema.ResourceData. I will leave this as-is after all.
* feat(synthetics): add labels resource * docs(synthetics) add website docs for synthetics labels resource * chore: vendor modules
Resolves #164.
This PR adds a new synthetics labels resource, following existing patterns.