-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(alert_policy): add ability to add multiple channels to a policy #398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
size/L
label
Feb 13, 2020
sanderblue
commented
Feb 13, 2020
sanderblue
commented
Feb 13, 2020
…cy via alert_policy resource
…amples, update import section
sanderblue
force-pushed
the
feat/multiple-channels-per-policy
branch
from
February 13, 2020 02:46
bcf0a2a
to
17d8ccf
Compare
sanderblue
force-pushed
the
feat/multiple-channels-per-policy
branch
from
February 13, 2020 18:15
17d8ccf
to
4bf2d5a
Compare
zlesnr
approved these changes
Feb 13, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work. This looks good to me.
kidk
pushed a commit
to aminoz007/terraform-provider-newrelic
that referenced
this pull request
Oct 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #319
The PR introduces the ability to add alert channels to a policy during resource creation by allowing the user to supply an array of channel IDs in their Terraform config for a
newrelic_alert_policy
resource.Example:
It should be noted that the user will not be able to import the channel IDs. However, a user can still import the primary resource, add channel IDs to their HCL, and then use
terraform apply
to add the channels to the policy.