feat(infra_alert_condition): add violation_close_timer to newrelic_infra_alert_condition resource #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
sanderblue
force-pushed
the
feat/infra-violation-close-timer
branch
2 times, most recently
from
5a946ac
to
d2d9442
Compare
sanderblue
force-pushed
the
feat/infra-violation-close-timer
branch
from
d2d9442
to
24079b7
Compare
zlesnr
approved these changes
Jan 31, 2020
|
Looks good to me. The interface casting bits look a bit strange, but the tests are passing. |
…fra_alert_condition resource
ctrombley
force-pushed
the
feat/infra-violation-close-timer
branch
from
24079b7
to
cc14ab4
Compare
|
I'm trying to use this attribute in 1.17.1 and it's not working for violation_close_timer = 0. It just sets the value to default (24) on all newrelic_infra_alert_condition resources upon create. Running apply again, the resource realizes the mismatch and plans to change the violation_close_timer 24 => 0. Executing the plan, however, fails to actually change the value, so there's a perpetual state mismatch. There's no way to have no violation close timer except to ignore the attribute and manually set it on each alarm condition outside of Terraform |
|
^ I've opened an issue #553 |
kidk
pushed a commit
to aminoz007/terraform-provider-newrelic
that referenced
this pull request
Oct 12, 2021
…fra_alert_condition resource (newrelic#370)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #156