Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

masterauth password included in inventory #41

Closed
1 of 7 tasks
rabbitt opened this issue Aug 2, 2019 · 5 comments
Closed
1 of 7 tasks

masterauth password included in inventory #41

rabbitt opened this issue Aug 2, 2019 · 5 comments

Comments

@rabbitt
Copy link
Contributor

rabbitt commented Aug 2, 2019

masterauth password included in inventory

Currently only requirepass is stripped from the inventory, but masterauth remains. This should be stripped as well. Expect a PR shortly.

OS
  • All of them
  • Amazon Linux, all versions
  • CentOS, version 6 or higher
  • Debian, version 7 ("Wheezy") or higher
  • Red Hat Enterprise Linux (RHEL), version 6 or higher
  • Ubuntu, versions 12.04, 14.04, and 16.04 (LTS versions)
  • Windows Server, 2008 and 2012 and their service packs
@rabbitt
Copy link
Contributor Author

rabbitt commented Aug 2, 2019

@xino12 Any chance you, or someone else, could look at this soon? This is honestly kind of a critical issue here as people using replication will have their requirepass exposed in NewRelic inventory through the masterauth config...

@mariomac
Copy link
Contributor

mariomac commented Aug 5, 2019

Hi @rabbitt , thank you for your contribution. We are looking into your patch and provide a release soon.

@mariomac
Copy link
Contributor

mariomac commented Aug 5, 2019

Redis Integration v1.2.1 has been released. Thank you for your collaboration.

@mariomac mariomac closed this as completed Aug 5, 2019
@rabbitt
Copy link
Contributor Author

rabbitt commented Aug 5, 2019

Hi @mariomac, If I can find time to finish it, I'll have another feature soon too - wildcard keys that must both respect key_limit and be prefixed with a string >= 1 character (e.g., keys: '["foo:*", "bar", "baz", "neato:123:*"])

@tormodmacleod
Copy link

Hi @mariomac, If I can find time to finish it, I'll have another feature soon too - wildcard keys that must both respect key_limit and be prefixed with a string >= 1 character (e.g., keys: '["foo:*", "bar", "baz", "neato:123:*"])

@rabbitt did you ever get anywhere with this? being able to use wildcards would be a great workaround for hashicorp/terraform-provider-helm#1292

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants