Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify autodiscovery for kubelet considering new Arch #219

Closed
paologallinaharbur opened this issue Oct 4, 2021 · 1 comment
Closed

Modify autodiscovery for kubelet considering new Arch #219

paologallinaharbur opened this issue Oct 4, 2021 · 1 comment
Assignees
Labels
feature request Categorizes issue or PR as related to a new feature or enhancement.

Comments

@paologallinaharbur
Copy link
Member

paologallinaharbur commented Oct 4, 2021

Taking into account that the process needs to be longrunning verify

  • what we are actually caching/discovering regarding kubelet
  • if we can simplify that code or improve performances thanks the re-arch
@invidian invidian added the feature request Categorizes issue or PR as related to a new feature or enhancement. label Oct 11, 2021
@invidian
Copy link
Contributor

Some questions and thoughts arised while we were discussing #217:

  • Kubelet discovery process is not about where to connect, almost, as most of the time we connect via host IP, however, in cases like Fargate, we will be connecting over API server proxy endpoint.
  • Kubelet discovery is mainly about how to connect to kubelet endpoint, so either with TLS, without TLS or with insecure TLS.
  • We need to decide on strategy for discovery while having a long-running process. Do we want to make a discovery only once during initialization of the integration and then just re-use this? Kubelet might be re-configured in the meanwhile, however, for such situations, the recommended way is to taint and drain the node, change the configuration and then schedule the workloads again. However, DaemonSets does not get unscheduled in such cases, so agent will not be restarted. But generally speaking, this seems like an exotic feature to support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Categorizes issue or PR as related to a new feature or enhancement.
Projects
None yet
Development

No branches or pull requests

3 participants