From df0675c48a5290549c41961b3f359b9f4a954ece Mon Sep 17 00:00:00 2001 From: Amit Yathirajadasan Date: Tue, 29 Oct 2024 11:26:23 -0700 Subject: [PATCH 1/2] fix: add check for composing on save in edit-in-place --- src/components/edit-in-place/index.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/components/edit-in-place/index.js b/src/components/edit-in-place/index.js index 34d0524..d3cbe40 100644 --- a/src/components/edit-in-place/index.js +++ b/src/components/edit-in-place/index.js @@ -75,7 +75,7 @@ const EditInPlace = forwardRef( const keyDownHandler = useCallback((evt) => { const { ctrlKey, metaKey, keyCode } = evt; // save on enter - if (keyCode === 13) { + if (!evt?.nativeEvent?.isComposing && keyCode === 13) { evt.preventDefault(); editableRef.current.blur(); } From cd9b6b083812196ba5135b7b6fddce3ce351d5e5 Mon Sep 17 00:00:00 2001 From: Amit Yathirajadasan Date: Tue, 29 Oct 2024 11:28:08 -0700 Subject: [PATCH 2/2] chore: update changelog --- CHANGELOG.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 318e862..feb9bb3 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ## [Unreleased] +### Fixed + +- EditInPlace - prevents save when in composition session + ## [1.23.4] - 2024-09-20 ### Fixed