chore: Recapture IE final harvest (dev bug) NR-139090 #605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwli24
added
bug
bjfield
approved these changes
Jun 26, 2023
metal-messiah
approved these changes
Jun 26, 2023
metal-messiah
approved these changes
Jun 26, 2023
|
Approved, can you plz run WDIO tests as well to confirm that this change does not break the IE tests there? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a same-version patch to #576
Overview
#576 made the final harvest on page unload unreliable for IE11. This reintroduces reliability to that browser, while keeping usage of img out, 414 too-long-url at bay, and existing behavior for other browsers.
Related Issue(s)
NR-139090
Testing
Existing tests are sufficient -- this fixes failing IE functional on pvt/timings.
Verify that for IE, final analytics are sent when page is dismissed like for the other browser versions.