Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Send CLS as timing node additionally #935

Merged
merged 1 commit into from
Apr 2, 2024
Merged

feat: Send CLS as timing node additionally #935

merged 1 commit into from
Apr 2, 2024

Conversation

cwli24
Copy link
Contributor

@cwli24 cwli24 commented Mar 28, 2024

cumulativeLayoutShift can now be queried for (with that as its timingName) as its own PageViewTiming event in New Relic. The additional attribution are a part of these events, and the values are more reflective of true end-session CLS scores.

Overview

Uncomment cls timing node for attribution.

Related Issue(s)

https://new-relic.atlassian.net/browse/NR-239252

Testing

Full test suite

Copy link

Asset Size Report

Merging this pull request will result in the following asset size changes:

Agent Asset Previous Size New Size Diff
lite loader 31.98 kB / 11.17 kB (gzip) 31.98 kB / 11.18 kB (gzip) 0% / 0.03% (gzip)
lite async-chunk 50.57 kB / 16.36 kB (gzip) 50.68 kB / 16.39 kB (gzip) 0.22% / 0.21% (gzip)
pro loader 51.14 kB / 17.4 kB (gzip) 51.14 kB / 17.4 kB (gzip) 0% / 0.01% (gzip)
pro async-chunk 91.96 kB / 28.07 kB (gzip) 92.07 kB / 28.1 kB (gzip) 0.12% / 0.12% (gzip)
spa loader 59.71 kB / 20 kB (gzip) 59.71 kB / 20 kB (gzip) 0% / 0.01% (gzip)
spa async-chunk 106.18 kB / 32.25 kB (gzip) 106.29 kB / 32.28 kB (gzip) 0.11% / 0.11% (gzip)
lite-polyfills loader 127.21 kB / 40.89 kB (gzip) 127.21 kB / 40.89 kB (gzip) 0% / 0% (gzip)
lite-polyfills async-chunk 63.99 kB / 18.51 kB (gzip) 64.11 kB / 18.58 kB (gzip) 0.19% / 0.36% (gzip)
pro-polyfills loader 147.24 kB / 46.81 kB (gzip) 147.24 kB / 46.82 kB (gzip) 0% / 0.01% (gzip)
pro-polyfills async-chunk 126.32 kB / 32.97 kB (gzip) 126.44 kB / 33 kB (gzip) 0.09% / 0.1% (gzip)
spa-polyfills loader 155.26 kB / 48.93 kB (gzip) 155.26 kB / 48.93 kB (gzip) 0% / 0% (gzip)
spa-polyfills async-chunk 142.82 kB / 37.42 kB (gzip) 142.94 kB / 37.45 kB (gzip) 0.08% / 0.09% (gzip)

Copy link

github-actions bot commented Mar 28, 2024

Static Badge

Last ran on March 28, 2024 12:05:13 CDT
Checking merge of (db630f1) into main (22dcf6d)

Copy link

codecov bot commented Mar 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.56%. Comparing base (22dcf6d) to head (db630f1).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #935      +/-   ##
==========================================
+ Coverage   80.55%   80.56%   +0.01%     
==========================================
  Files         154      154              
  Lines        7065     7066       +1     
  Branches     1394     1395       +1     
==========================================
+ Hits         5691     5693       +2     
+ Misses       1172     1170       -2     
- Partials      202      203       +1     
Flag Coverage Δ
integration-tests 90.01% <100.00%> (+0.05%) ⬆️
unit-tests 58.37% <100.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cwli24 cwli24 marked this pull request as ready for review March 28, 2024 17:38
@cwli24 cwli24 changed the title chore: Add CLS as node back in feat: Send CLS as timing node additionally Mar 29, 2024
@cwli24 cwli24 merged commit 88e71da into main Apr 2, 2024
52 of 53 checks passed
@cwli24 cwli24 deleted the cls-pvt-node branch April 2, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants