Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add rum-response metadata handler #913

Merged
merged 11 commits into from
Mar 20, 2024
Merged

feat: Add rum-response metadata handler #913

merged 11 commits into from
Mar 20, 2024

Conversation

metal-messiah
Copy link
Member

@metal-messiah metal-messiah commented Mar 8, 2024

The initial connect call can now supply browser app metadata. This adds a handler to store and use that metadata for future harvests.

Overview

This PR introduces a handler for the agent metadata response from the RUM call. This will initially contain a real entityGuid for the browser app, regardless if it was APM injected or standalone. The entityGuid implementations will be introduced in subsequent PRs, as it will be applied to SR, ST and Logs payloads in the future.

Related Issue(s)

NR-215487

Testing

A new test has been added to account for the rum-supplied app id.

Copy link

github-actions bot commented Mar 8, 2024

Static Badge

Last ran on March 08, 2024 17:15:11 CST
Checking merge of (433915d) into main (dfdbaab)

Copy link

github-actions bot commented Mar 8, 2024

Asset Size Report

Merging this pull request will result in the following asset size changes:

Agent Asset Previous Size New Size Diff
lite loader 32.46 kB / 11.31 kB (gzip) 32.48 kB / 11.32 kB (gzip) 0.05% / 0.08% (gzip)
lite async-chunk 46.45 kB / 15.27 kB (gzip) 46.48 kB / 15.3 kB (gzip) 0.08% / 0.14% (gzip)
pro loader 51.63 kB / 17.54 kB (gzip) 51.64 kB / 17.55 kB (gzip) 0.03% / 0.05% (gzip)
pro async-chunk 87.67 kB / 26.96 kB (gzip) 87.79 kB / 27.01 kB (gzip) 0.13% / 0.17% (gzip)
spa loader 60.2 kB / 20.16 kB (gzip) 60.21 kB / 20.17 kB (gzip) 0.02% / 0.04% (gzip)
spa async-chunk 101.79 kB / 31.1 kB (gzip) 101.9 kB / 31.14 kB (gzip) 0.11% / 0.15% (gzip)
lite-polyfills loader 128.8 kB / 41.08 kB (gzip) 128.82 kB / 41.1 kB (gzip) 0.01% / 0.03% (gzip)
lite-polyfills async-chunk 58.81 kB / 17.4 kB (gzip) 58.99 kB / 17.47 kB (gzip) 0.31% / 0.4% (gzip)
pro-polyfills loader 148.83 kB / 47.04 kB (gzip) 148.85 kB / 47.04 kB (gzip) 0.01% / 0.01% (gzip)
pro-polyfills async-chunk 121.11 kB / 31.83 kB (gzip) 121.29 kB / 31.91 kB (gzip) 0.15% / 0.27% (gzip)
spa-polyfills loader 156.85 kB / 49.14 kB (gzip) 156.87 kB / 49.15 kB (gzip) 0.01% / 0.02% (gzip)
spa-polyfills async-chunk 136.46 kB / 36.5 kB (gzip) 136.64 kB / 36.57 kB (gzip) 0.13% / 0.2% (gzip)

Copy link

codecov bot commented Mar 8, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 80.40%. Comparing base (4081c03) to head (ad685ad).

Files Patch % Lines
src/features/page_view_event/aggregate/index.js 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #913      +/-   ##
==========================================
- Coverage   80.42%   80.40%   -0.02%     
==========================================
  Files         154      154              
  Lines        7044     7048       +4     
  Branches     1386     1388       +2     
==========================================
+ Hits         5665     5667       +2     
- Misses       1163     1165       +2     
  Partials      216      216              
Flag Coverage Δ
unit-tests 58.38% <40.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metal-messiah metal-messiah merged commit 2c99a5b into main Mar 20, 2024
16 of 18 checks passed
@metal-messiah metal-messiah deleted the rum-agent-meta branch March 20, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants