fix: Fix webpack imports in npm package #905
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing some import overrides in our NPM package build to prevent imports existing that include code reliant on webpack globals. This will resolve the error
Uncaught ReferenceError: __webpack_require__ is not defined
when using the NPM package in a project that does not use webpack.Overview
Our import overrides for the couple of files that access webpack globals was not being applied correctly. This resulted in imports for code that relied on webpack globals in the NPM package. If the customer is not using webpack, this will result in a runtime error.
Related Issue(s)
https://new-relic.atlassian.net/browse/NR-233660
Testing
I could not find a good way to test this issue in an automated way. To verify manually, search the
dist
directory for imports ofnonce
andpublic-path