fix: TraceId generation regression (non-random trace ids) #853
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a regression which caused all trace ids generated to end in a 0.
Overview
A previous fix for trace ids ending in 00 had a commit added that provided tests and some other fixes, unfortunately this commit partially reverted the 00 fix, causing the traceids to end in 0.
Note: The added tests do not seem to detect issues with the randomness of the trace ids and this PR does not attempt to remedy this.
Related Issue(s)
#854
Testing
Please see (#825) for detailed testing instructions.