Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: TraceId generation regression (non-random trace ids) #853

Merged
merged 1 commit into from
Jan 5, 2024

Conversation

paddyo
Copy link
Contributor

@paddyo paddyo commented Jan 4, 2024

Fixes a regression which caused all trace ids generated to end in a 0.

Overview

A previous fix for trace ids ending in 00 had a commit added that provided tests and some other fixes, unfortunately this commit partially reverted the 00 fix, causing the traceids to end in 0.

Note: The added tests do not seem to detect issues with the randomness of the trace ids and this PR does not attempt to remedy this.

Related Issue(s)

#854

Testing

Please see (#825) for detailed testing instructions.

@paddyo paddyo marked this pull request as ready for review January 4, 2024 11:24
Copy link

codecov bot commented Jan 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cb23dbd) 78.24% compared to head (3dd4f6b) 78.24%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #853   +/-   ##
=======================================
  Coverage   78.24%   78.24%           
=======================================
  Files         142      142           
  Lines        6358     6358           
  Branches     1228     1228           
=======================================
  Hits         4975     4975           
  Misses       1176     1176           
  Partials      207      207           
Flag Coverage Δ
unit-tests 55.10% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cwli24 cwli24 merged commit 8767f69 into newrelic:main Jan 5, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants