-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Session Replay Dynamic Loading #832
Conversation
Asset Size Report
Merging this pull request will result in the following asset size changes:
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #832 +/- ##
==========================================
+ Coverage 78.37% 78.59% +0.21%
==========================================
Files 142 144 +2
Lines 6359 6410 +51
Branches 1229 1250 +21
==========================================
+ Hits 4984 5038 +54
+ Misses 1169 1167 -2
+ Partials 206 205 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of minor comments but otherwise looks good.
Allow Session Replay modules to load earlier in the page lifecycle if a replay is ongoing
Overview
This PR enables earlier loading of SR recording libs by doing the following:
Changes to note:
Related Issue(s)
https://new-relic.atlassian.net/browse/NR-186806
Testing