-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fix API Warning Messages #830
Conversation
Asset Size Report
Merging this pull request will result in the following asset size changes:
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #830 +/- ##
==========================================
- Coverage 78.25% 78.24% -0.02%
==========================================
Files 142 142
Lines 6355 6356 +1
Branches 1228 1228
==========================================
Hits 4973 4973
- Misses 1175 1176 +1
Partials 207 207
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would rather use a private class function instead of a function outside the class but either is fine.
Fix warning messages given by API calls made before the agent has initialized
Overview
The Agent gave an incorrect message for
setUserId
when called before the agent was initialized. This change aligns all API calls to give the same generic message.Related Issue(s)
NR-186348
Testing
All tests should be unaffected