Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix API Warning Messages #830

Merged
merged 2 commits into from
Dec 5, 2023
Merged

fix: Fix API Warning Messages #830

merged 2 commits into from
Dec 5, 2023

Conversation

metal-messiah
Copy link
Member

Fix warning messages given by API calls made before the agent has initialized

Overview

The Agent gave an incorrect message for setUserId when called before the agent was initialized. This change aligns all API calls to give the same generic message.

Related Issue(s)

NR-186348

Testing

All tests should be unaffected

@metal-messiah metal-messiah changed the title set api messaging to unified response fix: Fix API Warning Messages Dec 4, 2023
Copy link

github-actions bot commented Dec 4, 2023

Asset Size Report

Merging this pull request will result in the following asset size changes:

Agent Asset Previous Size New Size Diff
lite loader 31.05 kB / 10.54 kB (gzip) 30.36 kB / 10.53 kB (gzip) -2.24% / -0.09% (gzip)
lite async-chunk 45.58 kB / 15.05 kB (gzip) 45.58 kB / 15.05 kB (gzip) 0% / 0% (gzip)
pro loader 48.45 kB / 15.96 kB (gzip) 47.76 kB / 15.94 kB (gzip) -1.43% / -0.08% (gzip)
pro async-chunk 74.48 kB / 23.75 kB (gzip) 74.48 kB / 23.75 kB (gzip) 0% / 0% (gzip)
spa loader 54.91 kB / 17.93 kB (gzip) 54.21 kB / 17.92 kB (gzip) -1.27% / -0.06% (gzip)
spa async-chunk 89.25 kB / 28.16 kB (gzip) 89.25 kB / 28.16 kB (gzip) 0% / 0% (gzip)
lite-polyfills loader 122.57 kB / 39.56 kB (gzip) 122.2 kB / 39.6 kB (gzip) -0.3% / 0.11% (gzip)
lite-polyfills async-chunk 57.97 kB / 17.25 kB (gzip) 57.97 kB / 17.25 kB (gzip) 0% / 0% (gzip)
pro-polyfills loader 142.09 kB / 45.45 kB (gzip) 141.76 kB / 45.37 kB (gzip) -0.23% / -0.17% (gzip)
pro-polyfills async-chunk 101.74 kB / 27.34 kB (gzip) 101.74 kB / 27.34 kB (gzip) 0% / 0% (gzip)
spa-polyfills loader 150.11 kB / 47.61 kB (gzip) 149.78 kB / 47.51 kB (gzip) -0.22% / -0.21% (gzip)
spa-polyfills async-chunk 117.31 kB / 31.93 kB (gzip) 117.31 kB / 31.93 kB (gzip) 0% / 0% (gzip)

Copy link

codecov bot commented Dec 4, 2023

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (1c98d29) 78.25% compared to head (2ce6ce4) 78.24%.
Report is 1 commits behind head on main.

Files Patch % Lines
src/loaders/agent-base.js 0.00% 13 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #830      +/-   ##
==========================================
- Coverage   78.25%   78.24%   -0.02%     
==========================================
  Files         142      142              
  Lines        6355     6356       +1     
  Branches     1228     1228              
==========================================
  Hits         4973     4973              
- Misses       1175     1176       +1     
  Partials      207      207              
Flag Coverage Δ
unit-tests 55.09% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metal-messiah metal-messiah marked this pull request as ready for review December 4, 2023 18:21
Copy link
Contributor

@patrickhousley patrickhousley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would rather use a private class function instead of a function outside the class but either is fine.

@metal-messiah metal-messiah merged commit 2b13a0f into main Dec 5, 2023
13 of 15 checks passed
@metal-messiah metal-messiah deleted the api-messaging branch December 5, 2023 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants