Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add SR to pro and spa builds (only runs for LP customers) #677

Merged
merged 2 commits into from
Sep 6, 2023

Conversation

metal-messiah
Copy link
Member

Add the SR feature to Pro and Pro+Spa builds of the agent. The session replay library shipping with this version of the browser agent is in limited preview and is not turned on by default. To use the feature, users will need to be part of the limited preview customer group and configure their browser application settings in the UI.

Overview

This PR exposes the SR feature to the pro and spa builds of the agent.

Related Issue(s)

https://issues.newrelic.com/browse/NR-156695

Testing

Tests should be unaffected

@metal-messiah metal-messiah changed the title feat: Add SR to pro and spa builds (only run for LP customers) feat: Add SR to pro and spa builds (only runs for LP customers) Sep 5, 2023
@metal-messiah metal-messiah marked this pull request as ready for review September 5, 2023 20:48
@github-actions
Copy link

github-actions bot commented Sep 5, 2023

Asset Size Report

Merging this pull request will result in the following asset size changes:

Agent Asset Previous Size New Size Diff
lite loader 28.25 kB / 9.8 kB (gzip) 28.25 kB / 9.8 kB (gzip) 0% / 0% (gzip)
lite async-chunk 45.4 kB / 15.03 kB (gzip) 45.4 kB / 15.03 kB (gzip) 0% / 0% (gzip)
pro loader 45.35 kB / 15.2 kB (gzip) 45.53 kB / 15.23 kB (gzip) 0.4% / 0.14% (gzip)
pro async-chunk 64.45 kB / 20.82 kB (gzip) 64.45 kB / 20.82 kB (gzip) 0% / 0% (gzip)
spa loader 51.76 kB / 17.16 kB (gzip) 51.94 kB / 17.18 kB (gzip) 0.35% / 0.13% (gzip)
spa async-chunk 78.67 kB / 25.04 kB (gzip) 78.67 kB / 25.04 kB (gzip) 0% / 0% (gzip)
lite-polyfills loader 98.71 kB / 31.43 kB (gzip) 98.71 kB / 31.43 kB (gzip) 0% / 0% (gzip)
lite-polyfills async-chunk 57.86 kB / 17.24 kB (gzip) 57.86 kB / 17.24 kB (gzip) 0% / 0% (gzip)
pro-polyfills loader 118.3 kB / 37.37 kB (gzip) 118.69 kB / 37.41 kB (gzip) 0.33% / 0.12% (gzip)
pro-polyfills async-chunk 98.82 kB / 26.62 kB (gzip) 98.82 kB / 26.62 kB (gzip) 0% / 0% (gzip)
spa-polyfills loader 126.27 kB / 39.5 kB (gzip) 126.67 kB / 39.55 kB (gzip) 0.31% / 0.11% (gzip)
spa-polyfills async-chunk 113.7 kB / 31.03 kB (gzip) 113.7 kB / 31.03 kB (gzip) 0% / 0% (gzip)
worker loader 40.36 kB / 13.66 kB (gzip) 40.36 kB / 13.66 kB (gzip) 0% / 0% (gzip)
worker async-chunk 45.36 kB / 15.37 kB (gzip) 45.36 kB / 15.37 kB (gzip) 0% / 0% (gzip)

@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Merging #677 (680ddcb) into main (71d47d6) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #677   +/-   ##
=======================================
  Coverage   86.15%   86.15%           
=======================================
  Files         138      138           
  Lines        5237     5237           
  Branches      719      719           
=======================================
  Hits         4512     4512           
  Misses        660      660           
  Partials       65       65           
Flag Coverage Δ
unit-tests 79.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/cdn/pro.js 100.00% <ø> (ø)
src/cdn/spa.js 100.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@patrickhousley patrickhousley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of QQ. Should we add the two additional bundles created for SR to the PR size check output? Should we add additional details to our library size doc page regarding the two additional bundles required for SR?

@metal-messiah
Copy link
Member Author

Just a couple of QQ. Should we add the two additional bundles created for SR to the PR size check output? Should we add additional details to our library size doc page regarding the two additional bundles required for SR?

yes, and yes. And also a disclaimer on the doc page that those SR async bundles are only ever loaded after all the mechanisms for sampling and entitlements are ran

@metal-messiah metal-messiah merged commit 6d8ddb4 into main Sep 6, 2023
14 checks passed
@metal-messiah metal-messiah deleted the expose-sr branch September 6, 2023 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants