-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add SR to pro and spa builds (only runs for LP customers) #677
Conversation
Asset Size Report
Merging this pull request will result in the following asset size changes:
|
Codecov Report
@@ Coverage Diff @@
## main #677 +/- ##
=======================================
Coverage 86.15% 86.15%
=======================================
Files 138 138
Lines 5237 5237
Branches 719 719
=======================================
Hits 4512 4512
Misses 660 660
Partials 65 65
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of QQ. Should we add the two additional bundles created for SR to the PR size check output? Should we add additional details to our library size doc page regarding the two additional bundles required for SR?
yes, and yes. And also a disclaimer on the doc page that those SR async bundles are only ever loaded after all the mechanisms for sampling and entitlements are ran |
Add the SR feature to Pro and Pro+Spa builds of the agent. The session replay library shipping with this version of the browser agent is in limited preview and is not turned on by default. To use the feature, users will need to be part of the limited preview customer group and configure their browser application settings in the UI.
Overview
This PR exposes the SR feature to the pro and spa builds of the agent.
Related Issue(s)
https://issues.newrelic.com/browse/NR-156695
Testing
Tests should be unaffected