fix: Undefined deny list ignores block internal #629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Asset Size ReportMerging this pull request will result in the following CDN asset size changes:
Merging this pull request will result in the following NPM package consumer size changes:
Other Standard CDN AssetsReleased Assets
Built Assets
Other Polyfill CDN AssetsReleased Assets
Built Assets
|
Codecov Report
@@ Coverage Diff @@
## main #629 +/- ##
==========================================
+ Coverage 68.04% 68.06% +0.02%
==========================================
Files 130 130
Lines 6017 6018 +1
Branches 1140 1141 +1
==========================================
+ Hits 4094 4096 +2
+ Misses 1579 1578 -1
Partials 344 344
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
metal-messiah
approved these changes
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In cases where the customer's configuration does not include the
init.ajax.deny_listproperty, the agent would not properly account for theinit.ajax.block_internalsetting and would not block ajax events for internal agent network calls.Overview
In cases where the customer's configuration does not include the
init.ajax.deny_listproperty, the agent would not properly account for theinit.ajax.block_internalsetting and would not block ajax events for internal agent network calls.This may be an edge case for most of customers since most have at least the BAM endpoint in their deny list. For customers with an empty deny list in their browser entity settings, this fix will now apply the
block_internalsetting properly.Related Issue(s)
These are just related tickets. This issue was found while troubleshooting these tickets.
https://issues.newrelic.com/browse/NR-146248
https://issues.newrelic.com/browse/NR-147189
Testing
Running the local server with no changes to settings should now block ajax events for the local server. You can use the fetch test page to verify.