-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add error mode to session trace - NEWRELIC-8666 NEWRELIC-9283 #583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwli24
added
small
Small Engineering Effort
MMF
Work directly planned for in an MMF
labels
Jun 13, 2023
bjfield
changed the title
feat: Add error mode to sessioned traces - NEWRELIC-8666 NEWRELIC-9283
feat: Add error mode to session-enabled traces - NEWRELIC-8666 NEWRELIC-9283
Jun 15, 2023
@bjfield new title longer than 70 chars |
cwli24
changed the title
feat: Add error mode to session-enabled traces - NEWRELIC-8666 NEWRELIC-9283
feat: Add error mode to session trace - NEWRELIC-8666 NEWRELIC-9283
Jun 16, 2023
metal-messiah
approved these changes
Jun 16, 2023
patrickhousley
approved these changes
Jun 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Session-enabled traces now have an "error mode" capability in which the feature lies dormant until an exception is thrown. Upon the error, the past 30 seconds of data is retained and sent, and the feature becomes fully activated again.
Overview
Following #545, Trace can now run in error mode, which makes it silent until such time an error occurs and it starts harvesting the 30 seconds prior and in full thereafter. (Similar to experimental Replay.)
Some timer nodes are also removed (evaluated as ok) to reduce noise in reported data.
Related Issue(s)
NEWRELIC-8666
NEWRELIC-9283
Testing
All workflows from #545 should remain unaffected.
In addition, these should now hold true as well:
stn:1
, Trace will run fully and normally, harvesting everything regardless of Replay mode.stn:0
, Trace mode will mirror Replay mode (abiding by truth table): off to off, full to full, error to error.ptid
REPLAY_ABORTED
event is emitted,runtime.session.state.sessionTraceMode = 0
) on the new tab, switching back to the starting page causes its mode to change respectively as well.