feat: Add Firefox to LCP test matcher #1223
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Firefox versions 122 and above to LCP test matcher since versions 122 and above now support collection of LCP web vital timings.
Overview
Add Firefox versions 122 and above to LCP test matcher since versions 122 and above now support collection of LCP web vital timings. CLS matcher now uses a separate SpecMatcher object.
These changes are needed to keep test consistency with browser additions and features. Web standards change constantly on what browsers support what standard and we need to keep up to date on them.
Related Issue(s)
https://new-relic.atlassian.net/browse/NR-328547
Testing
Make sure tests pass. Check that Firefox 122+ is additionally tested for: