Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Firefox to LCP test matcher #1223

Merged
merged 1 commit into from
Oct 21, 2024
Merged

Conversation

ellisong
Copy link
Contributor

@ellisong ellisong commented Oct 18, 2024

Add Firefox versions 122 and above to LCP test matcher since versions 122 and above now support collection of LCP web vital timings.

Overview

Add Firefox versions 122 and above to LCP test matcher since versions 122 and above now support collection of LCP web vital timings. CLS matcher now uses a separate SpecMatcher object.

These changes are needed to keep test consistency with browser additions and features. Web standards change constantly on what browsers support what standard and we need to keep up to date on them.

Related Issue(s)

https://new-relic.atlassian.net/browse/NR-328547

Testing

Make sure tests pass. Check that Firefox 122+ is additionally tested for:

  • LCP is not collected on hidden pages for rum agent
  • LCP is not collected on hidden pages for spa agent

Copy link

Asset Size Report

Merging this pull request will result in the following asset size changes:

Agent Asset Previous Size New Size Diff
lite loader 28.85 kB / 10.52 kB (gzip) 28.85 kB / 10.52 kB (gzip) 0% / 0% (gzip)
lite async-chunk 52.79 kB / 17.17 kB (gzip) 52.79 kB / 17.17 kB (gzip) 0% / 0% (gzip)
pro loader 49.84 kB / 17.28 kB (gzip) 49.84 kB / 17.28 kB (gzip) 0% / 0% (gzip)
pro async-chunk 101.36 kB / 30.98 kB (gzip) 101.36 kB / 30.98 kB (gzip) 0% / 0% (gzip)
spa loader 57.5 kB / 19.63 kB (gzip) 57.5 kB / 19.63 kB (gzip) 0% / 0% (gzip)
spa async-chunk 116.42 kB / 35.31 kB (gzip) 116.42 kB / 35.31 kB (gzip) 0% / 0% (gzip)

Copy link

codecov bot commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.43%. Comparing base (daf349e) to head (fa2e4c9).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1223      +/-   ##
==========================================
- Coverage   88.44%   88.43%   -0.02%     
==========================================
  Files         169      169              
  Lines        7365     7365              
  Branches     1507     1507              
==========================================
- Hits         6514     6513       -1     
- Misses        725      726       +1     
  Partials      126      126              
Flag Coverage Δ
integration-tests 91.58% <ø> (-0.03%) ⬇️
unit-tests 79.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Oct 18, 2024

Static Badge

Last ran on October 18, 2024 15:03:54 CDT
Checking merge of (fa2e4c9) into main (daf349e)

@ellisong ellisong enabled auto-merge (squash) October 18, 2024 20:42
@ellisong ellisong merged commit c6a20e1 into main Oct 21, 2024
31 of 38 checks passed
@ellisong ellisong deleted the firefox-lcp-test-matcher branch October 21, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants