Skip to content

Latest commit

 

History

History
35 lines (20 loc) · 2.91 KB

12-tests.md

File metadata and controls

35 lines (20 loc) · 2.91 KB

Tests

Types of Testing

Unit Tests

We utilize PHPUnit for unit testing. Where applicable, unit tests should be written for all new code, or updated for existing code, by the team developing the functionality or making the change.

Component Tests

Cypress should be used for component-based testing of React components. Where applicable, component tests should be written for all new code, or updated for existing code, by the team developing the functionality or making the change.

End-to-End Tests

Cypress should be used for end-to-end testing of the WordPress environment. Where applicable, end-to-end tests should be written for all new code, or updated for existing code, by the team developing the functionality or making the change.

Module Tests

Each module should include end-to-end Cypress tests. The tests should be located in the directory tests/cypress/integration/. Brand plugins will load tests for each module in that plugin via the Cypress configuration and can test module functionality in PRs and when publishing releases. Tests should reference Cypress environment variables for things like paths which expect the brand. For instance, '/wp-admin/admin.php?page=bluehost#/settings' would become '/wp-admin/admin.php?page=' + Cypress.env('pluginId') + '#/settings', making it implementable in any brand plugin. If additional environment variables are needed, they can be added to the cypress.config.js file in the plugins for now. If these need to be located within the module, we can work out a way to load them dynamically as well.

For more examples, please refer to the CTB or Staging modules, both of which have been updated to include tests and even demonstrate how to use fixtures.

This marks a departure from the previous practice where all tests were located in the plugin. The reason for this change is to relocate the tests into the module, bringing the code closer to the corresponding code being tested. This also helps eliminate duplication of test files since each test was duplicated in every brand plugin. When a test needed to be modified in a module, it required updating the test in each plugin. This adjustment allows the tests to be situated nearer to the code they are intended to assess and reduces the duplication of test files.

Furthermore, this change brings us closer to the long-term goal of having workflows within the module to run tests before tagging a release. For the time being, it's important to ensure that tests pass locally before tagging a release, so we avoid a series of module releases solely to achieve passing tests in the plugin.

Where possible, new features and bug fixes should include a test to verify the feature or fix and ensure that the feature or fix remains functional.

Best Practices

When writing end-to-end tests, test functionality not code. For example, "This page is the color I expect and all text is visible", NOT "this page has the CSS class I expect".