Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default behaviour should be to not automatically set any Lambda environment variables #89

Open
3 tasks
neverendingqs opened this issue Feb 6, 2021 · 0 comments

Comments

@neverendingqs
Copy link
Owner

neverendingqs commented Feb 6, 2021

Right now, all Lambda function environments are configured with all variables in the dotenv file(s). This can easily cause security issues by setting environment variables that contain secrets (e.g. SENTRY_SECRET gets set when none of the Lambda functions use it). As well, it can cause confusion on what is happening on different environments (e.g. #65).

The new default value should be functionally equivalent to:

custom:
  dotenv:
    include: []
  • Update README to recommend new safe default
  • Update README to warn about deprecation
  • Add or update toggle to switch behaviour on major version bump
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant