chore: update hermes #ntrn-1 #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
foxpy
requested changes
Jul 30, 2023
There was a problem hiding this comment.
- please add cross-links between each PR so it is easy to find them together (and also easier to merge them together later);
- take a look at this document. it suggests to install old hermes, you'll have to update it;
- this example relies on old hermes version and has outdated config.toml, it has to be updated, too.
foxpy
requested changes
Aug 1, 2023
There was a problem hiding this comment.
Thank you for your fixes, I have acknowledged them! There is one more thing, running make init && make start-rly prints out this warning:
2023-08-01T10:53:47.344307Z WARN ThreadId(35) health_check{chain=test-1}: Chain 'test-1' has no minimum gas price value configured for denomination 'untrn'. This is usually a sign of misconfiguration, please check your chain and relayer configurations
The same for test-2 chain. This probably has to be fixed?
|
Actually, this issue should be reflected in config.toml in one of neutron-sdk's examples, too 🤔 |
|
Okay, so this config is in the chain itself, not hermes config. More strange is that we have this setting written in app.toml on init |
🤔 wow that's very interesting I am approving this PR anyway, nice job! |
foxpy
previously approved these changes
Aug 1, 2023
pr0n00gler
approved these changes
Aug 3, 2023
foxpy
approved these changes
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updates hermes config to be used with hermes 1.6.0
parts of task: