segfault around (dis)connection

[metalefty]

Using devel head f745376.
X.Org X Server 1.17.4.
10.2-RELEASE-p9 FreeBSD.

[  7644.110] rdpDeferredUpdateCallback: reschedual rect_id 69522 rect_id_ack 69521
[  7695.951] rdpClientConSendMsg: overrun error len 316256 count 2
[  7695.955] rdpClientConSend: g_tcp_send failed(returned -1)
[  7695.955] rdpClientConDisconnect:
[  7695.955] rdpClientConDisconnect: clientCon removed from dev list
[  7695.955] rdpClientConSendMsg: error in rdpup_send_msg
[  7695.955] rdpClientConSendPending: rdpClientConSendMsg failed
[  7695.955] (EE) Segmentation fault at address 0x81e677540
[  7695.956] (EE)
Fatal server error:
[  7695.956] (EE) Caught signal 11 (Segmentation fault). Server aborting
[  7695.956] (EE)
[  7695.956] (EE)
Please consult the The X.Org Foundation support
         at http://wiki.x.org
 for help.
[  7695.956] (EE) Please also check the log file at "/var/log/Xorg.20.log" for additional information.
[  7695.956] (EE)
[  7695.956] rdpmouseControl: what 4
[  7695.956] rdpkeybControl: what 4
[  7695.956] rdpLeaveVT:
[  7695.956] (EE) Server terminated with error (1). Closing log file.

[jsorg71]

I think it's about the overrun error. The buffer is only 32K.
This shouldn't happen, everywhere should call rdpClientConPreCheck before appending a new message. There must do someplace that does not.

[metalefty]

Probably in rdpClientConProcessMsgClientInfo.

More log here:

$ grep -v rdpDeferredUpdateCallback /var/log/Xorg.20.log.old
(snip)
[  1167.430] rdpClientConProcessMsgClientInput: invalidate x 0 y 0 cx 1919 cy 1199
[  1195.373] rdpRRGetPanning: 0x8034cf500
[  1195.923] rdpRRGetPanning: 0x8034cf500
[  1196.243] rdpRRGetPanning: 0x8034cf500
[  1196.433] rdpRRGetPanning: 0x8034cf500
[  1196.803] rdpRRGetPanning: 0x8034cf500
[  1197.017] rdpRRGetPanning: 0x8034cf500
[  1197.152] rdpRRGetPanning: 0x8034cf500
[  1197.275] rdpRRGetPanning: 0x8034cf500
[  1197.470] rdpRRGetPanning: 0x8034cf500
[  1197.636] rdpRRGetPanning: 0x8034cf500
[  1197.754] rdpRRGetPanning: 0x8034cf500
[  1197.898] rdpRRGetPanning: 0x8034cf500
[  1215.310] rdpClientConProcessMsgClientInput: invalidate x 0 y 0 cx 1919 cy 1199
[  1261.297] rdpClientConProcessMsgClientInput: invalidate x 0 y 0 cx 1919 cy 1199
[  1557.290] rdpClientConProcessMsgClientInput: invalidate x 0 y 0 cx 1919 cy 1199
[  2104.928] rdpRRGetPanning: 0x8034cf500
[  2446.591] rdpSaveScreen:
[  2714.006] rdpRRGetPanning: 0x8034cf500
[  3544.809] rdpClientConProcessMsgClientInput: invalidate x 0 y 0 cx 1919 cy 1199
[  3544.836] rdpSaveScreen:
[  4104.894] rdpClientConProcessMsgClientInput: invalidate x 0 y 0 cx 1919 cy 1199
[  5147.579] rdpClientConProcessMsgClientInput: invalidate x 0 y 0 cx 1919 cy 1199
[  7040.558] rdpClientConProcessMsgClientInput: invalidate x 0 y 0 cx 1919 cy 1199
[  7695.951] rdpClientConSendMsg: overrun error len 316256 count 2
[  7695.955] rdpClientConSend: g_tcp_send failed(returned -1)
[  7695.955] rdpClientConDisconnect:
[  7695.955] rdpClientConDisconnect: clientCon removed from dev list
[  7695.955] rdpClientConSendMsg: error in rdpup_send_msg
[  7695.955] rdpClientConSendPending: rdpClientConSendMsg failed
[  7695.955] (EE) Segmentation fault at address 0x81e677540
[  7695.956] (EE)
Fatal server error:
[  7695.956] (EE) Caught signal 11 (Segmentation fault). Server aborting
[  7695.956] (EE)
[  7695.956] (EE)
Please consult the The X.Org Foundation support
         at http://wiki.x.org
 for help.
[  7695.956] (EE) Please also check the log file at "/var/log/Xorg.20.log" for additional information.
[  7695.956] (EE)
[  7695.956] rdpmouseControl: what 4
[  7695.956] rdpkeybControl: what 4
[  7695.956] rdpLeaveVT:
[  7695.956] (EE) Server terminated with error (1). Closing log file.

[metalefty]

Merging into #62.