Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Rule paths are difficult to modify #15

Closed
eliperelman opened this issue Mar 7, 2017 · 2 comments
Closed

Rule paths are difficult to modify #15

eliperelman opened this issue Mar 7, 2017 · 2 comments

Comments

@eliperelman
Copy link
Member

Interacting with the include and exclude APIs for Rule are not friendly, as they only allow adding paths to the Set. Any other operations require using the backing store at _include and _exclude. We should make these work similar to a ChainedSet, but this will mean another breaking change.
@eliperelman
Copy link
Member Author

Keeping in the spirit of making these chainable, I suppose that both the .loader and .plugin APIs don't easily allow changes either, whether being removed or cleared, etc. sigh

@eliperelman
Copy link
Member Author

These have now been resolved by #16. Released with v3.0.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eliperelman