This repository has been archived by the owner on Feb 18, 2024. It is now read-only.
Reduce verbosity of webpack compile output #1072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Example log output using yarn buildBefore: After: yarn startBefore: After: yarn testBefore: After: Even more extreme is when building a project with multiple entrypoints and a large dependency graph (such as Treeherder): yarn buildBefore: After: |
eliperelman
reviewed
Sep 4, 2018
There was a problem hiding this comment.
Making middleware changes in the neutrino package feels like a violation of separation of concerns since it does nothing else to force middleware that I can remember. I'm willing to be convinced otherwise, but I feel like we should duplicate this into the lower level middleware like web and node.
packages/neutrino/index.js
Outdated
| @@ -31,6 +31,13 @@ module.exports = (middleware = {}) => { | |||
| neutrino.config.mode(mode); | |||
| } | |||
|
|
|||
| // The default output is too noisy, particularly with multiple entrypoints. | |||
There was a problem hiding this comment.
This feels like the wrong place to make this change. I know it's more duplication, but I would rather this lived in the middleware/presets instead of here.
There was a problem hiding this comment.
We set the mode in the neutrino package, which is why I put this alongside that (though mode is probably unavoidable given args handling).
I guess we'd only need to duplicate it three times (web/node/library).
This adjusts the console output to be less verbose, for parity with how it was prior to the switch to native CLIs in #852. In some cases the output has been made to be even more concise than in Neutrino 8, since it's now possible for users to adjust the output via CLI flags, therefore less important to satisfy all use-cases out of the box. For that reason the `debug` handling has also been removed. The output when using webpack-dev-server now includes the duration, which makes it much easier to compare incremental build times. The `performance.hints(false)` of `@neutrinojs/node` has been removed since it's redundant as of webpack 4.2.0: webpack/webpack@c65fb74 Fixes #897.
|
PR updated :-) On a separate note, I think #635 would be a great idea - we can just switch to using Jest snapshots for the sanity-checking of the generated webpack config - will reduce the manual duplication. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adjusts the console output to be less verbose, for parity with how it was prior to the switch to native CLIs in #852.
In some cases the output has been made to be even more concise than in Neutrino 8, since it's now possible for users to adjust the output via CLI flags, therefore less important to satisfy all use-cases out of the box. For that reason the
debughandling has also been removed.The output when using webpack-dev-server now includes the duration, which makes it much easier to compare incremental build times.
The
performance.hints(false)of@neutrinojs/nodehas been removed since it's redundant as of webpack 4.2.0:webpack/webpack@c65fb74
Fixes #897.