Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

running reports with neurostore reference dataset takes **a lot** of memory #879

Open
jdkent opened this issue Feb 8, 2024 · 5 comments
Assignees
Labels
bug Issues noting problems and PRs fixing those problems.

Comments

@jdkent
Copy link
Member

jdkent commented Feb 8, 2024

Summary

Additional details

  • NiMARE version:

What were you trying to do?

What did you expect to happen?

What actually happened?

Reproducing the bug

@jdkent jdkent added the bug Issues noting problems and PRs fixing those problems. label Feb 8, 2024
@JulioAPeraza
Copy link
Collaborator

JulioAPeraza commented May 31, 2024

Did you see this high memory issue with CBMA or IBMA?

@jdkent
Copy link
Member Author

jdkent commented Jun 1, 2024

CBMA

@JulioAPeraza JulioAPeraza self-assigned this Oct 2, 2024
@JulioAPeraza
Copy link
Collaborator

@jdkent The peak memory usage comes from the last interactive plot:

plot_interactive_brain(img, fig_dir / "corrector_figure-interactive.html", threshold)

Should we set that to optional? We can define a parameter advanced=False that controls whether to show those in the report.

@jdkent
Copy link
Member Author

jdkent commented Oct 10, 2024

could this line be changed to a lower resolution?

template = datasets.load_mni152_template(resolution=1)

this is the figure for someone to navigate the statistical results, correct?

not the interactive surface viewer for the coordinates.

@jdkent
Copy link
Member Author

jdkent commented Oct 10, 2024

let's see what happens if we change the resolution to 2mm, potentially halves the memory consumption.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues noting problems and PRs fixing those problems.
Projects
None yet
Development

No branches or pull requests

2 participants