Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Point type vs Value type #1

Open
jdkent opened this issue Feb 3, 2022 · 1 comment
Open

Point type vs Value type #1

jdkent opened this issue Feb 3, 2022 · 1 comment

Comments

@jdkent
Copy link
Member

jdkent commented Feb 3, 2022

how does "type" defined in Point differ from the "type" defined in Value? Do they represent the same concept?
I think @tyarkoni has already explained this to me, but I cannot find my notes on it. @tyarkoni, could you remind me again if you have the time?

Point:

NIMADS/definitions.json

Lines 22 to 29 in 8b40695

"Point": {
"properties": [
["coordinates", "nimads:Coordinates"],
["space", "schema:Text"],
["value", "nimads:Value"],
["type", "schema:Text"]
]
},

Value:

NIMADS/definitions.json

Lines 30 to 35 in 8b40695

"Value": {
"properties": [
["type", "schema:Text"],
["value", "schema:Float"]
]
},

@tsalo
Copy link
Member

tsalo commented Aug 2, 2022

A Point can have multiple values of different types, right? For example, the parameter estimate (beta), variance of the estimate (varcope), test statistic (z, t, F, etc.), and even a standardized effect size (Cohen's d, Hedges g, etc.). I would imagine that information should go in the Value's "type" property, rather than in the Point's.

Perhaps Point "type" should be whether the Point refers to a cluster peak, a cluster sub-peak, or a cluster center of mass?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

2 participants